aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 27009: Use virtualenv to build pants instead of pex.
Date Wed, 22 Oct 2014 21:14:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27009/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 2:14 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
-------

Fix grammar in description.


Bugs: AURORA-876
    https://issues.apache.org/jira/browse/AURORA-876


Repository: aurora


Description (updated)
-------

Use virtualenv to build pants instead of pex.

The goal of this change is to reduce CI flakiness by using `pip install` rather than `pex`
to bootstrap pants. This still reaches out to external servers (and thus has the potential
to be flaky) but is at least configurable (via `--default-timeout`). In a future review we
can consider mirroring to svn.apache.org and disabling PyPI lookups.

This requires a change to production executor code to use `sys.executable` rather than chmod+x-ing
the runner PEX. Failure to do this results in the pants virtualenv's `site-packages` shadowing
the dependencies in the `pex` (fairly obviously as there is a test failure related to psutil1/2
conflicts). I'm sure I'm papering over a PEX bug here but IMO this is fine as the only reason
for it is to execute the thermos runner PEX under a different python interpreter than the
executor is using (based on the hash-bang in the pex). This is not a configuration we need
to support IMO.


Diffs
-----

  pants 168419d7d8f5d89a0d87bfc6ac9f06c9e8e3dbc2 
  src/main/python/apache/aurora/executor/thermos_task_runner.py f17910826c31c5bf754b43eb72500de639652f37


Diff: https://reviews.apache.org/r/27009/diff/


Testing
-------

git clean -fdx
./pants src/test/python:all


Thanks,

Kevin Sweeney


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message