aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 27047: Improve status command output ordering.
Date Wed, 22 Oct 2014 20:55:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27047/
-----------------------------------------------------------

(Updated Oct. 22, 2014, 4:55 p.m.)


Review request for Aurora, David McLaughlin and Zameer Manji.


Changes
-------

Use keyword parameters in thrift constructors instead of assignment.


Bugs: aurora-879
    https://issues.apache.org/jira/browse/aurora-879


Repository: aurora


Description
-------

- Sort tasks by instance number.
- Sort events by timestamp.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/jobs.py 10f8e0d331ca607e55e3aa6f96014caea744ed9f

  src/test/python/apache/aurora/client/cli/test_status.py 4f62cf0c52e5837309cf7ad702df6d907df8f510


Diff: https://reviews.apache.org/r/27047/diff/


Testing
-------

./pants src/test/python/apache/aurora/client/cli:job
Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
job)])
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
plugins: cov, timeout
collected 58 items

src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
src/test/python/apache/aurora/client/cli/test_create.py ...........
src/test/python/apache/aurora/client/cli/test_diff.py ...
src/test/python/apache/aurora/client/cli/test_kill.py ................
src/test/python/apache/aurora/client/cli/test_open.py .....
src/test/python/apache/aurora/client/cli/test_restart.py ........
src/test/python/apache/aurora/client/cli/test_status.py .............

========================== 58 passed in 3.65 seconds ===========================
src.test.python.apache.aurora.client.cli.job                                    .....   SUCCESS


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message