aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 26982: Make v2 job status look more like v1.
Date Tue, 21 Oct 2014 18:01:50 GMT


> On Oct. 21, 2014, 1:57 p.m., David McLaughlin wrote:
> > Is there an end to end test for this that needs updated?

No. The end-to-end doesn't check the output from the status command.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26982/#review57622
-----------------------------------------------------------


On Oct. 21, 2014, 12:19 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26982/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2014, 12:19 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: AURORA-874
>     https://issues.apache.org/jira/browse/AURORA-874
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adds a header line to each task in a task status line specifying
> the instance number, host, etc., the way v1 did. (We had originally planned
> not to display that information in v2, but we also have tests that depend on it being
present.)
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/jobs.py 7bbde156e64e969c6d402a04aaf7c038b919693a

>   src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8

> 
> Diff: https://reviews.apache.org/r/26982/diff/
> 
> 
> Testing
> -------
> 
> $ ./pants src/test/python/apache/aurora/client/cli:job
> Build operating on top level addresses: set([BuildFileAddress(/Users/mchucarroll/Code/incubator-aurora/src/test/python/apache/aurora/client/cli/BUILD,
job)])
> ============================= test session starts ==============================
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 62 items
> 
> src/test/python/apache/aurora/client/cli/test_cancel_update.py ..
> src/test/python/apache/aurora/client/cli/test_create.py ...........
> src/test/python/apache/aurora/client/cli/test_diff.py ...
> src/test/python/apache/aurora/client/cli/test_kill.py ................
> src/test/python/apache/aurora/client/cli/test_open.py .....
> src/test/python/apache/aurora/client/cli/test_restart.py ........
> src/test/python/apache/aurora/client/cli/test_status.py ............
> src/test/python/apache/aurora/client/cli/test_update.py .....
> 
> ========================== 62 passed in 6.42 seconds ===========================
> src.test.python.apache.aurora.client.cli.job                                    .....
  SUCCESS
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message