aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 26956: Use toLocalTime angular filter rather than duplicate logic in controller
Date Tue, 21 Oct 2014 00:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26956/
-----------------------------------------------------------

(Updated Oct. 21, 2014, 12:40 a.m.)


Review request for Aurora, Joshua Cohen and Kevin Sweeney.


Changes
-------

Use bullet points instead of dashes as a delimiter.


Bugs: AURORA-873
    https://issues.apache.org/jira/browse/AURORA-873


Repository: aurora


Description
-------

Fixes the AM/PM issue by using 24 hour clock format that was already defined in filters.js.



Diffs (updated)
-----

  src/main/resources/scheduler/assets/js/controllers.js f8e2eb7b896843bb19ad3ea5108532209603c73c

  src/main/resources/scheduler/assets/taskStatus.html ae32866ff241e18d04a82e8a7f909cb692657188


Diff: https://reviews.apache.org/r/26956/diff/


Testing
-------

See attached screenshot. 


File Attachments
----------------

screenshot
  https://reviews.apache.org/media/uploaded/files/2014/10/20/d89be4fc-7fae-4746-841a-ccaf66e2439e__Screen_Shot_2014-10-20_at_3.55.15_PM.png


Thanks,

David McLaughlin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message