aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26856: Adding storage configuration summary.
Date Fri, 17 Oct 2014 21:18:18 GMT


> On Oct. 17, 2014, 2:46 p.m., Jay Buffington wrote:
> > docs/storage_config.md, line 2
> > <https://reviews.apache.org/r/26856/diff/1/?file=723958#file723958line2>
> >
> >     A summary here would be good to help give an overview of what the point of this
document is and who the intended audience is.

Done.


> On Oct. 17, 2014, 2:46 p.m., Jay Buffington wrote:
> > docs/storage_config.md, line 15
> > <https://reviews.apache.org/r/26856/diff/1/?file=723958#file723958line15>
> >
> >     It is not clear what application these flags are for.  The scheduler binary,
right?  Maybe link to a page that enumerates all flags.

Clarified. Unfortunately, we don't have a page fully describing all available options. Filed
AURORA-869.


> On Oct. 17, 2014, 2:46 p.m., Jay Buffington wrote:
> > docs/storage_config.md, line 19
> > <https://reviews.apache.org/r/26856/diff/1/?file=723958#file723958line19>
> >
> >     This is a knit, but I would s/this document/the replicated log configuration
document/;

Modified.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26856/#review57139
-----------------------------------------------------------


On Oct. 17, 2014, 3:16 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26856/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 3:16 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-839
>     https://issues.apache.org/jira/browse/AURORA-839
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding config summary for storage.
> 
> 
> Diffs
> -----
> 
>   docs/storage_config.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26856/diff/
> 
> 
> Testing
> -------
> 
> https://github.com/maxim111333/incubator-aurora/blob/storage_config_summary/docs/storage_config.md
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message