aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26664: Deprecating SANDBOX_DELETED task state.
Date Fri, 17 Oct 2014 16:15:11 GMT


> On Oct. 15, 2014, 12:41 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/gc_executor.py, line 281
> > <https://reviews.apache.org/r/26664/diff/1/?file=719806#file719806line281>
> >
> >     More context?  It's not clear what you mean here.

Added.


> On Oct. 15, 2014, 12:41 a.m., Bill Farner wrote:
> > src/main/resources/scheduler/assets/js/controllers.js, line 530
> > <https://reviews.apache.org/r/26664/diff/1/?file=719807#file719807line530>
> >
> >     Can this flag just be removed now?

It would require deeper UI changes than I am comfortable to address in this CR.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26664/#review56621
-----------------------------------------------------------


On Oct. 13, 2014, 11:22 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26664/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2014, 11:22 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-751
>     https://issues.apache.org/jira/browse/AURORA-751
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Dropping the SANDBOX_DELETED from the scheduler.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java cfab57896f9c76754ba3b42742504fb7e7a2cf79

>   src/main/java/org/apache/aurora/scheduler/base/Jobs.java 9ba83fa93409de7c6254bd8e7cc27e6bc10186e0

>   src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java 0f6731106c53420b92e60b9faf26c3614bd7ae00

>   src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java 86a8eb57ce7074f71d5212b34defe4320a5c430d

>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 8c20ab6f2bebf1d1c0f91fed3f1e48361cdf45d6

>   src/main/python/apache/aurora/executor/gc_executor.py 9b40adaaa3634a451b4047915485e0e97d8f7914

>   src/main/resources/scheduler/assets/js/controllers.js 7e9037ee921b009dc2b7c5adcf057bedebb01632

>   src/main/resources/scheduler/assets/js/filters.js 7e8ca8408628d6f658da4267eb763e8fb4cb68c9

>   src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 606c4434b7158220ccf1403b6deac939021fee31

>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1

>   src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 53d2c6bb78ad08a84639c1ecd48ba64d17c3f9fc

>   src/test/java/org/apache/aurora/scheduler/base/JobsTest.java f3b6ff0aa72c873d6b3cf3a1d327033c791ff6b9

>   src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java eccf0c757d1e6addcd7619120f96ffa5f1ac38b5

>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java cb3254728a697a963b92baff31b02dafa2be0039

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 80646a685ea918d80efafc5773e5805000a9c012

> 
> Diff: https://reviews.apache.org/r/26664/diff/
> 
> 
> Testing
> -------
> 
> ./gradle -Pq build
> Verified UI in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message