aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26836: Draft of cron documentation
Date Fri, 17 Oct 2014 00:09:03 GMT


> On Oct. 16, 2014, 11:10 p.m., Bill Farner wrote:
> > docs/cron-jobs.md, line 9
> > <https://reviews.apache.org/r/26836/diff/1/?file=723471#file723471line9>
> >
> >     This is slightly confusing, i thought this file existed in the repo.  Can you
reword to make it obvious that the user is to _create_ this file?
> 
> Kevin Sweeney wrote:
>     This is actually a bug in the patch - updated patch forthcoming.

Aha, i thought that might be the case.  Now i'll post my original concern: these files will
drift.  Since we lack a means to include the file contents, consider linking to it instead.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26836/#review57032
-----------------------------------------------------------


On Oct. 16, 2014, 11:32 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26836/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 11:32 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-440
>     https://issues.apache.org/jira/browse/AURORA-440
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Initial shot at cron documentation.
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 83d0d104554753dab939bf8d25b83e9adb00758a 
>   docs/cron-jobs.md PRE-CREATION 
>   examples/jobs/cron_hello_world.aurora PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26836/diff/
> 
> 
> Testing
> -------
> 
> Pushed to https://github.com/kevints/incubator-aurora/blob/kts/cron-docs/docs/cron-jobs.md
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message