aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Pan" <david.p...@gmail.com>
Subject Re: Review Request 26383: Health Check Disabler
Date Thu, 16 Oct 2014 22:04:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 3:04 p.m.)


Review request for Aurora, Joe Smith, Maxim Khutornenko, and Zameer Manji.


Changes
-------

Added warning about permanently disabling health checks in user guide.


Bugs: AURORA-795
    https://issues.apache.org/jira/browse/AURORA-795


Repository: aurora


Description
-------

The health check disabler allows health checks for a job to be snoozed temporarily by touching
a snooze file in the job's sandbox.  The appropriate unit tests were modified/added.

The corresponding JIRA ticket is the following:
https://issues.apache.org/jira/browse/AURORA-795


Diffs (updated)
-----

  docs/user-guide.md e12ee89b043e34d06348ae3ddbbe8363244fca7c 
  src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163

  src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653

  src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec


Diff: https://reviews.apache.org/r/26383/diff/


Testing
-------

On vagrant in ~/aurora, I ran
./pants src/test/python/apache/aurora/executor::


Thanks,

David Pan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message