aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26821: Handle resourceOffers callback asynchronsly.
Date Thu, 16 Oct 2014 21:12:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26821/#review57001
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java
<https://reviews.apache.org/r/26821/#comment97440>

    remove newline



src/main/java/org/apache/aurora/scheduler/SchedulerModule.java
<https://reviews.apache.org/r/26821/#comment97442>

    // TODO(zmanji): Create singleThreadedExecutor (non-scheduled) variant.


- Bill Farner


On Oct. 16, 2014, 8:59 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26821/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 8:59 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-848
>     https://issues.apache.org/jira/browse/AURORA-848
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Handle resourceOffers callback asynchronsly.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java e4439f6a28535f774cfdc1000a0d6d2976254aee

>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 31c8650a2cf211290ea4197f97c840f78cfd7646

>   src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 606b5b03616c8ddbc83cb89f1206feb409f187c2

> 
> Diff: https://reviews.apache.org/r/26821/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew clean build
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message