aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26790: Fix redirect loop when accessing rewritten paths.
Date Thu, 16 Oct 2014 19:16:40 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26790/#review56974
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java
<https://reviews.apache.org/r/26790/#comment97410>

    Can you include a comment here for posterity?


- Bill Farner


On Oct. 16, 2014, 4:02 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26790/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2014, 4:02 a.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-841
>     https://issues.apache.org/jira/browse/AURORA-841
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix redirect loop when accessing rewritten paths.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java fe1e111ff556a463e7f1f90c4c785b0bc0b59ddc

>   src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java e50de1eac86ed449b79ba66e0d6c5a488bc01a3f

>   src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java 53c708866e8abcb1e951265c707ff34e2331a3c4

> 
> Diff: https://reviews.apache.org/r/26790/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> Also started up multiple schedulers in vagrant image and confirmed that I'm properly
redirected when accessing the non-leading scheduler.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message