aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Smith" <yasumo...@gmail.com>
Subject Re: Review Request 26802: Set a default for the error log dir
Date Thu, 16 Oct 2014 17:51:40 GMT


> On Oct. 16, 2014, 10:24 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/cli/test_aurora_command_line.py, line 31
> > <https://reviews.apache.org/r/26802/diff/1/?file=722892#file722892line31>
> >
> >     Expand 'm' to something more meaningful?

Done


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26802/#review56942
-----------------------------------------------------------


On Oct. 15, 2014, 11:02 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26802/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 11:02 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-827
>     https://issues.apache.org/jira/browse/AURORA-827
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Set a default for the error log dir
> 
> This has been a weird  issue to wrap my head around, it's really using lots of low-level
systems (writing tracebacks to files) so I feel like I've done some weird things in the tests.
Feedback and critque welcome + appreciated.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8

>   src/test/python/apache/aurora/client/cli/BUILD d33e86643a59879c115876c98bd1dc19aa7ae61c

>   src/test/python/apache/aurora/client/cli/test_aurora_command_line.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26802/diff/
> 
> 
> Testing
> -------
> 
> [tw-172-25-132-201 aurora (yasumoto/error_log_dir_default)]$ ./pants src/test/python/apache/aurora/client/cli:aurora_command_line
> Build operating on top level addresses: set([BuildFileAddress(/Users/jsmith/workspace/aurora/src/test/python/apache/aurora/client/cli/BUILD,
aurora_command_line)])
> ==================================================================== test session starts
=====================================================================
> platform darwin -- Python 2.7.5 -- py-1.4.25 -- pytest-2.6.3
> plugins: cov, timeout
> collected 1 items 
> 
> src/test/python/apache/aurora/client/cli/test_aurora_command_line.py .
> 
> ================================================================== 1 passed in 0.63 seconds
==================================================================
> src.test.python.apache.aurora.client.cli.aurora_command_line                    .....
  SUCCESS
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message