aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26753: Start removing clientv1.
Date Wed, 15 Oct 2014 18:17:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26753/#review56756
-----------------------------------------------------------


> Note: end-to-end tests are failing, but in the same way as they fail without this change.
I'm working on debugging that, but it should be its own change/review, and I don't want to
delay reviewing this.

I agree.  Probably goes without saying, but let's get the end-to-end tests green before putting
this on master.

- Bill Farner


On Oct. 15, 2014, 4:20 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26753/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 4:20 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: aurora-131
>     https://issues.apache.org/jira/browse/aurora-131
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Make the "aurora2" main target be the standalone clientv2;
> - Don't build the bridged client by default; but allow forced build using "aurora2_bridge".
> - Modify cli tests so that they only depend on the standalone clientv2.
> - Modify vagrant config to make clientv2 the primary client.
> - Modify end-to-end tests to match the vagrant changes.
> 
> (Note: end-to-end tests are failing, but in the same way as they fail without this change.
I'm working on debugging that, but it should be its own change/review, and I don't want to
delay reviewing this.)
> 
> 
> Diffs
> -----
> 
>   docs/developing-aurora-client.md e1b2ccd7504f983169118a288721894184d67c97 
>   examples/vagrant/aurorabuild.sh a27636655d722ca79f66b377fd847954d52e8feb 
>   examples/vagrant/provision-dev-cluster.sh 740bc212ba604b2c64af92eba1be41e8ed3fdbde

>   src/main/python/apache/aurora/client/cli/BUILD 995570325bbb09ecbcc2ace5d223760c5d49367f

>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py a2b28ba23961284ba60358af54726e0386dd69b6

>   src/test/python/apache/aurora/client/cli/test_cancel_update.py e7052465411165acb3d5145664f2f166ac052500

>   src/test/python/apache/aurora/client/cli/test_command_hooks.py 9fc6fe2c2063cda494437d83044557b345acacea

>   src/test/python/apache/aurora/client/cli/test_config_noun.py dfcbd7217b1d51609fa01c4d9cefed5471c91718

>   src/test/python/apache/aurora/client/cli/test_create.py 427f7ce4476b48d407b8bd2bf2c54c52e6e63079

>   src/test/python/apache/aurora/client/cli/test_cron.py c7b71c29d44150162fec8066947623fa91815424

>   src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68

>   src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d

>   src/test/python/apache/aurora/client/cli/test_inspect.py e997b9743b63d71f8624ecf5ca1dcae0227be70d

>   src/test/python/apache/aurora/client/cli/test_kill.py bac4485fa105848d96e2505c4a2ea2eee45dc968

>   src/test/python/apache/aurora/client/cli/test_logging.py 9ca4dceeaa87d5fb2e38fe0d83fdcdf1ee597a0e

>   src/test/python/apache/aurora/client/cli/test_open.py c20649f5cada241d0f6e9ae5f88d300eac073517

>   src/test/python/apache/aurora/client/cli/test_plugins.py dc5edd4f03cee062673231a04908193480c8071c

>   src/test/python/apache/aurora/client/cli/test_quota.py 88fb9aec4d1eae6ad05da01752a670f902bafb1b

>   src/test/python/apache/aurora/client/cli/test_restart.py a5f94484b30ecb8417116db9ce12c015957357c5

>   src/test/python/apache/aurora/client/cli/test_sla.py a1a3d8161ba747aa23a5e614e9ae31473d2058c1

>   src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8

>   src/test/python/apache/aurora/client/cli/test_supdate.py 6775c389cb1a0b80dd17fe179e8b98d4e9db0332

>   src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b

>   src/test/python/apache/aurora/client/cli/test_update.py cff1b6578aec6f5bcc1e610e58b47af233f32b41

>   src/test/sh/org/apache/aurora/e2e/test_common.sh 43d2516133c6d6cdb4236358f942396f057f739c

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 324aa4dbeff00e673fe73b87e3a0766856cd213c

>   src/test/sh/org/apache/aurora/e2e/test_end_to_end_v2.sh 8f4d2b01c9fa5a6ec9e8885a2d4fa0e9c3abb8a1

> 
> Diff: https://reviews.apache.org/r/26753/diff/
> 
> 
> Testing
> -------
> 
> - Ran all unit tests, confirmed they continue to pass.
> - Ran end-to-end tests (both v1 and v2 variants) with the updated setup, and verified
that they fail in exactly the same way as before this change.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message