aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 26688: Fix errors in help rendering:
Date Wed, 15 Oct 2014 17:57:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 1:57 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Update description of the logging level parameter.


Bugs: aurora-831
    https://issues.apache.org/jira/browse/aurora-831


Repository: aurora


Description
-------

- Put plugin-generated options into the correct order.
- Include the option-name in the detailed help list.
- Add missing metavars.


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8

  src/main/python/apache/aurora/client/cli/options.py dc76c25b90acb9610e40b939e65c3cabf032649f

  src/main/python/apache/aurora/client/cli/standalone_client.py 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1

  src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d


Diff: https://reviews.apache.org/r/26688/diff/


Testing
-------

New help output:
{noformat}
[sun-wukong incubator-aurora (deprecate)]$ ./dist/aurora2.pex help cron deschedule
Usage for verb "cron deschedule":
  deschedule   [--verbose-logging]   [--logging-level=numeric_level]   [--error-log-dir=error-log-dir]
[--bind=var=value] CLUSTER/ROLE/ENV/NAME
Options:
  --bind=var=value
  	Bind a pystachio variable name to a value. Multiple flags may be used to specify multiple
values.
  CLUSTER/ROLE/ENV/NAME
  	Fully specified job key, in CLUSTER/ROLE/ENV/NAME format
  --verbose-logging
  	Show verbose logging, including all logs up to level INFO (equivalent to --logging-level=20)
  --logging-level=numeric_level
  	Set logging to a specific numeric level.
  --error-log-dir=error-log-dir
  	Directory location where error files containing stack traces should be written. If the
directory doesn't exist, it will be created

Remove the cron schedule for a job.
{noformat}


Thanks,

Mark Chu-Carroll


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message