aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 26688: Fix errors in help rendering:
Date Tue, 14 Oct 2014 17:31:26 GMT


> On Oct. 14, 2014, 1 p.m., Mark Chu-Carroll wrote:
> > src/test/python/apache/aurora/client/cli/test_help.py, line 75
> > <https://reviews.apache.org/r/26688/diff/1/?file=720844#file720844line75>
> >
> >     Yes, they are guaranteed to be unique. The argparse framework that this is built
on checks uniqueness, and raises an exception if there's any ambiguity.
> 
> Joshua Cohen wrote:
>     What about the second question (could an option name appearing elsewhere in the help
output cause this test to improperly pass)?

I don't think so - that would require *every* command to have option names that were superstrings
of every option in the plugins.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26688/#review56545
-----------------------------------------------------------


On Oct. 14, 2014, 11:07 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26688/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2014, 11:07 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Joshua Cohen.
> 
> 
> Bugs: aurora-831
>     https://issues.apache.org/jira/browse/aurora-831
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Put plugin-generated options into the correct order.
> - Include the option-name in the detailed help list.
> - Add missing metavars.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py da9d5b6ba4d22ba1f444341b97bbcfaf7889a4a8

>   src/main/python/apache/aurora/client/cli/options.py dc76c25b90acb9610e40b939e65c3cabf032649f

>   src/main/python/apache/aurora/client/cli/standalone_client.py 20f4d7ef43ba336a2b6d02cbf5656c97bdfa2ea1

>   src/test/python/apache/aurora/client/cli/test_help.py f73c8a3778b7d118ea2865f213b442a607fb4a7d

> 
> Diff: https://reviews.apache.org/r/26688/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message