aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26458: Adding wait loop into host_drain status monitoring.
Date Fri, 10 Oct 2014 21:55:09 GMT


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 52
> > <https://reviews.apache.org/r/26458/diff/1/?file=715840#file715840line52>
> >
> >     Is this provided so external modules can interact with the maintenance?

Correct. Just a general approach we follow elsewhere.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, lines 63-67
> > <https://reviews.apache.org/r/26458/diff/1/?file=715840#file715840line63>
> >
> >     move out to its own method?

Done.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/admin/host_maintenance.py, line 88
> > <https://reviews.apache.org/r/26458/diff/1/?file=715840#file715840line88>
> >
> >     Maybe just raise a normal exception instead? :)
> >     
> >     (and maybe log which hosts weren't moved?)

Returning not_drained instead.


> On Oct. 9, 2014, 12:07 a.m., Joe Smith wrote:
> > src/test/python/apache/aurora/admin/test_host_maintenance.py, line 55
> > <https://reviews.apache.org/r/26458/diff/1/?file=715841#file715841line55>
> >
> >     can you assert on how many times this was called?

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26458/#review55899
-----------------------------------------------------------


On Oct. 8, 2014, 9:40 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26458/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 9:40 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Brian Wickman.
> 
> 
> Bugs: AURORA-820
>     https://issues.apache.org/jira/browse/AURORA-820
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Throttling status check calls now at a predefined 5 second interval with a max timeout
of 5 minutes.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8

> 
> Diff: https://reviews.apache.org/r/26458/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message