aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@twopensource.com>
Subject Re: Review Request 26383: Health Check Disabler
Date Thu, 09 Oct 2014 18:00:21 GMT


> On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 66
> > <https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66>
> >
> >     FWIW i actually meant to suggest that the snooze has no concept of time at all.
 If the file is there, don't perform health checks.  When you want to re-enable health checks,
delete the file.  Happy to hear what others think about that.
> 
> Zameer Manji wrote:
>     Doesn't this mean user error can disable health checks forever? I think we should
treat disabling health checking as an exceptional state (since the proceses has opted in to
health checking) and therefore require user action (increasing mtime) to continue to stay
in this state.
> 
> Kevin Sweeney wrote:
>     Presumably we can trust the user here - health checking is after all opt-in via {{thermos.ports[health]}}.
Making it a simple on/off switch greatly simplifies the code on our end.

I'm very worried about introducing a feature which can allow unhealthy instances live forever.
Furthermore this information isn't exposed on the Aurora UI or Observer UI so there isn't
an easy way to check if an instance has health checking disabled or not. A user can be completely
oblivious that health checking of their instance has been disabled.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55985
-----------------------------------------------------------


On Oct. 8, 2014, 6:56 p.m., David Pan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26383/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 6:56 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The health check disabler allows health checks for a job to be snoozed temporarily by
touching a snooze file in the job's sandbox.  The appropriate unit tests were modified/added.
> 
> The corresponding JIRA ticket is the following:
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163

>   src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653

>   src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec

> 
> Diff: https://reviews.apache.org/r/26383/diff/
> 
> 
> Testing
> -------
> 
> On vagrant in ~/aurora, I ran
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> David Pan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message