aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.
Date Thu, 09 Oct 2014 15:32:52 GMT


> On Oct. 9, 2014, 2:32 p.m., Bill Farner wrote:
> > Ship It!

Hmm, i'm now getting a different coverage error when preparing to submit this:

    * What went wrong:
    Execution failed for task ':jacocoTestReport'.
    > Thanks for adding the first test coverage to: org/apache/aurora/scheduler/async/OfferQueue$OfferQueueImpl$2
please remove it from the legacyClassesWithoutCoverage list. Expression: (coverage == 0).
Values: coverage = 6
    
This remains after cleaning the reports directory.  Do you see that one as well?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26469/#review55979
-----------------------------------------------------------


On Oct. 9, 2014, 12:15 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26469/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2014, 12:15 a.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Kill code to serve ApiBeta help pages that's no longer used now that the content is served
directly.
> 
> 
> Diffs
> -----
> 
>   build.gradle 8f7eed0b58a00f8e5e0521512975087d5788b5b6 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java eaf63382f689a045f837847736ef24fa75dee874

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 62154045f49c5b23949dc739d735c3e5d3680b89

> 
> Diff: https://reviews.apache.org/r/26469/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> $ curl -I http://192.168.33.7:8081/apibeta/help/method/setQuota.html
> HTTP/1.1 200 OK
> Content-Type: text/html
> Vary: Accept-Encoding
> Content-Length: 0
> Server: Jetty(7.6.15.v20140411)
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message