aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26394: Deprecating Identity struct (renaming fields).
Date Thu, 09 Oct 2014 14:39:03 GMT


> On Oct. 9, 2014, 12:05 a.m., Bill Farner wrote:
> > Thanks again for leading this - i'm very happy to see momentum on removing `Identity`.
> > 
> > Stepping back - i wonder if we should re-evaluate the way we do field deprecations
now that we've established a protocol with JIRA and releases.  This might mean we don't need
to do the `DEPRECATED` mangling.  What do you think?
> 
> Maxim Khutornenko wrote:
>     I still think visual code reminder is quite beneficial in avoiding the use of deprecated
fields. The between-release time is just too long to remember what needs to be avoided when
coding far away from thrift schema. Besides, it helps validate the concept and will facilitate
later removal.

Right, they're basically our poor-man's deprecation warnings.  However, this field and file
(api.thrift) makes up part of our API, and any consumers of the thrift definition, or `/apibeta`
will be broken by it.  I don't think we can get around a formal deprecation process for field
renames.


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26394/#review55907
-----------------------------------------------------------


On Oct. 8, 2014, 11:39 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26394/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 11:39 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin, Mark Chu-Carroll, and Bill Farner.
> 
> 
> Bugs: AURORA-84
>     https://issues.apache.org/jira/browse/AURORA-84
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Part 1 of Identity struct deprecation: renaming fields.
> 
> 
> Diffs
> -----
> 
>   examples/jobs/hello_world.aurora fc7877c3a60e56e301d9ee1fabd73446afca7236 
>   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 5c75cc8cae53edfa069c85c37ebad34774682081

>   src/main/java/org/apache/aurora/scheduler/async/Preemptor.java e9f251508257cd7287ff00773e0073a3cd130df8

>   src/main/java/org/apache/aurora/scheduler/base/JobKeys.java a76c3fac71b35115064fba6644cff0066fd9e630

>   src/main/java/org/apache/aurora/scheduler/base/Query.java eded7a59eb394748b93d7fbc085a1bdf64b043cc

>   src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 865742171c11fbe5cf1469a69dd7258ec1be28c2

>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java a0cb7bf56aeb7edd92b25d8d69a739d87452777a

>   src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java 8c20ab6f2bebf1d1c0f91fed3f1e48361cdf45d6

>   src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 37176237fac336413267f3c8bb4e1b9a6255150c

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5dcae4a6132026504cf02093ad4c68ab521e4ab8

>   src/main/python/apache/aurora/client/api/instance_watcher.py b390aa8993205f1f6938f8c295e3c16a0bf4df6d

>   src/main/python/apache/aurora/client/api/sla.py b9b64680b15f5395ed6aca681b9b1c30ffe2822c

>   src/main/python/apache/aurora/client/cli/task.py c41484bdc27266443bc4e139e1ebb362a59be0f9

>   src/main/python/apache/aurora/client/commands/admin.py deee0250f3ba9837feeb92acc654f5b3b68b4e0f

>   src/main/python/apache/aurora/client/commands/core.py 58f419e674f1a9a0ae9da6faa2e39c8167bab597

>   src/main/python/apache/aurora/client/commands/ssh.py d2b8bf675556b924d3d63b545d036dc48a081486

>   src/main/python/apache/aurora/config/thrift.py 288fb40f65629c8fd4eb7d92c8bf02369237de3b

>   src/main/python/apache/aurora/executor/aurora_executor.py 2c6423d096656f426a4385f4edef6875ebad7049

>   src/main/python/apache/aurora/executor/common/announcer.py 74b2114d1ede7a4a4a68b78144f9b08bc994bd87

>   src/main/python/apache/aurora/executor/thermos_task_runner.py 7b346e253677ee9b42c57782f7f67ff63b6a0083

>   src/main/resources/scheduler/assets/js/controllers.js 7e9037ee921b009dc2b7c5adcf057bedebb01632

>   src/main/resources/scheduler/assets/js/services.js b744f375411e09b7f776e4a05ee5961227143439

>   src/main/thrift/org/apache/aurora/gen/api.thrift 8794731f4b3f1033588bdfa33c292e4796319a2a

>   src/test/java/org/apache/aurora/scheduler/MesosTaskFactoryImplTest.java e96974764844b5d1a3a05f6996075fccee209594

>   src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java 371ae87f5954fa5f092db1f6d21e2291d7576173

>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 606c4434b7158220ccf1403b6deac939021fee31

>   src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java f2d153f446247032ad9d8d173fb70870dbfdcca1

>   src/test/java/org/apache/aurora/scheduler/async/PreemptorImplTest.java 8ee84cda8670d117e2efa2d1a114da6f0d8315d6

>   src/test/java/org/apache/aurora/scheduler/async/RescheduleCalculatorImplTest.java 131bd826dfe47f40f3c27f29c095ed42953e316c

>   src/test/java/org/apache/aurora/scheduler/async/TaskGroupsTest.java efdde15939b2a851e38be53cceab395cc2cd82a1

>   src/test/java/org/apache/aurora/scheduler/async/TaskHistoryPrunerTest.java 53d2c6bb78ad08a84639c1ecd48ba64d17c3f9fc

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerImplTest.java 6534329a92bf005223fa8907cbe4a8a3a511e142

>   src/test/java/org/apache/aurora/scheduler/async/TaskSchedulerTest.java 9970948bace4c0ecbc51d6fc79270d77fb17bf87

>   src/test/java/org/apache/aurora/scheduler/base/TaskTestUtil.java b8b9c1b8cdf7b641976c583a71fdd9b0c14e6e5f

>   src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java
ee9587582bd7c45a446e8afe28930c18a97d2792 
>   src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java f3c7c5bd53df759432beda4fa46db49fd0514b42

>   src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java d2d3e86bb5acf3402f55188b9ae440412ef14b5a

>   src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java 6a9c4ee278ed3ee8222404504e571f20991c2ae2

>   src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 62154045f49c5b23949dc739d735c3e5d3680b89

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b58c8f363e6e7c72accaf590b2a7cb7bf24275ea

>   src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java 96a04389e6b14c4d1c0bdb4d06abc046e7ea2151

>   src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java
4d96761e04a342ad3564bdba4afdc889f27ac123 
>   src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java cdd29ea2b6fc92b967571028d299260556e16d42

>   src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java cb3254728a697a963b92baff31b02dafa2be0039

>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java fc12933cefdbfc03de5918de04172c0744d34588

>   src/test/java/org/apache/aurora/scheduler/storage/StorageBackfillTest.java 80646a685ea918d80efafc5773e5805000a9c012

>   src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 5ac15eccc05dff11e3541c168f74baf1e7f86c35

>   src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 3871dae68fcdc6402cb61a7244b46114617eecff

>   src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 39729b374fe4e383f9b5ada7d016923766df9af7

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemStorageTest.java abf6868b34a2fe68a4fd2a0268a6ca2e0d518c83

>   src/test/java/org/apache/aurora/scheduler/storage/mem/MemTaskStoreTest.java 3b61ff3c237de3ec5224a239d1756ce8d7093a52

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
>   src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java ddec9e63b48a525780747bcb52f80abe1b200726

>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java
5242a43b1c8a236b9420625a64ff24ad9ff75643 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java f739e6d1b1af6eea4875e03d32bfe88cef87b3ff

>   src/test/python/apache/aurora/client/api/test_instance_watcher.py ae1b24bf4e3291cb31b3129cabcacdf32db0c560

>   src/test/python/apache/aurora/client/api/test_sla.py 1117f24d5ad3640632a1dd728913ba73c8bec707

>   src/test/python/apache/aurora/client/api/test_updater.py e8eaa9e6aa5fb3bc52a7195c26d9bd8294256780

>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py a2b28ba23961284ba60358af54726e0386dd69b6

>   src/test/python/apache/aurora/client/cli/test_diff.py 10817695352687cdb5b0c3ed9720e3091b230e68

>   src/test/python/apache/aurora/client/cli/test_status.py c704daec5a6eee73c7092a201b168881853908e8

>   src/test/python/apache/aurora/client/cli/test_task_run.py 16fde14c03f6fd2c000e76625fad174835763f1b

>   src/test/python/apache/aurora/client/commands/test_admin.py 769545ba86a669685001e4483d95091cfbfb4097

>   src/test/python/apache/aurora/client/commands/test_diff.py c8d01456aa52fd61374b4f0960b5159da2cb235b

>   src/test/python/apache/aurora/client/commands/test_run.py 0c395f7a8106acf3d45842a6f536dfb74b71a309

>   src/test/python/apache/aurora/client/commands/test_ssh.py abb657ba397c23ddac6c6b188f70d1c4e34597a6

>   src/test/python/apache/aurora/client/commands/test_status.py 639763501348a35bff2f127e18780ac74852f51b

>   src/test/python/apache/aurora/config/test_thrift.py fd28313df2cfd5a9c7d00f6d329518b4caabacb2

>   src/test/python/apache/aurora/executor/common/test_announcer.py 56943351ca09c29580dd764bb2442f0fcd9fde74

>   src/test/python/apache/aurora/executor/test_thermos_executor.py f6ca4dfd0fd262361709361c48c93799837e0a54

> 
> Diff: https://reviews.apache.org/r/26394/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python:all
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message