aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py
Date Wed, 08 Oct 2014 23:45:44 GMT


> On Oct. 8, 2014, 7:08 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/client/commands/test_maintenance.py, line 117
> > <https://reviews.apache.org/r/26431/diff/1/?file=715028#file715028line117>
> >
> >     can this be a mock that we assert gets called 3 times?
> >     
> >     (This test is a little bit of an integration test since it goes in and is also
testing perform_maintenace, but a full refactor of this test may be too much for now)

Sure, reverted it.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26431/#review55859
-----------------------------------------------------------


On Oct. 8, 2014, 12:13 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26431/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, Joe Smith and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-806
>     https://issues.apache.org/jira/browse/AURORA-806
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moving post_drain script functionality into host_maintenance.py to support per batch
execution.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/admin/host_maintenance.py 9c2a9f77109791da574e1624d27b6b7096a2678e

>   src/main/python/apache/aurora/client/commands/maintenance.py e465d973e9f764076e18491e1691d44303c0f388

>   src/test/python/apache/aurora/admin/test_host_maintenance.py 40228df59e43bc6034f2dc651c166a0c4b78aea8

>   src/test/python/apache/aurora/client/commands/test_maintenance.py d86aaf677804301fa5ddf1f76dba552f4fafb8c3

> 
> Diff: https://reviews.apache.org/r/26431/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message