aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kevin Sweeney" <kevi...@apache.org>
Subject Re: Review Request 26425: Fixing quota checking for updates.
Date Wed, 08 Oct 2014 19:32:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26425/#review55865
-----------------------------------------------------------


I'm underwater on reviews and unable to review this promptly - please remove me from the People
line.

- Kevin Sweeney


On Oct. 7, 2014, 3:03 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26425/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 3:03 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney and Bill Farner.
> 
> 
> Bugs: AURORA-802
>     https://issues.apache.org/jira/browse/AURORA-802
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Rolling up prod consumption does not work for quota checking during job update intitiation
where per-instance filtering is required. Splitting the QuotaManager interface into 2 use
cases:
> - createJob/addInstances
> - startJobUpdate
> 
> Reverting the IResourceAggregate abstraction in QuotaManager in favor of task/update
objects to simplify handling.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 2442b06f318c8d0cefe60296950baa1b916b42f7

>   src/main/java/org/apache/aurora/scheduler/quota/QuotaUtil.java d197dd515eb646cb4babadf22e9cf6480a919060

>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 5dcae4a6132026504cf02093ad4c68ab521e4ab8

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java b58c8f363e6e7c72accaf590b2a7cb7bf24275ea

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
02cd8f712fff3d283abf8e3eb1b4dcab1e762ac2 
> 
> Diff: https://reviews.apache.org/r/26425/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> Also, tested various update scenarios in vagrant.
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message