aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26428: Fixing python style violations.
Date Wed, 08 Oct 2014 19:22:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26428/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 7:22 p.m.)


Review request for Aurora and Brian Wickman.


Changes
-------

Fixing more violations.


Repository: aurora


Description
-------

Pre-commit hook was no longer working properly. Added target to match jenkins definition.


Diffs (updated)
-----

  build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c 
  src/main/python/apache/aurora/executor/gc_executor.py a11feb910cd116f53c9949343dfe7ecbd17d793c

  src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf

  src/test/python/apache/aurora/client/cli/test_create.py 88d1b350b09012684bb4f7263657cdff083df215

  src/test/python/apache/aurora/client/cli/test_inspect.py b64fbf9864693d8758baf01ba2293df525adebb7

  src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1

  src/test/python/apache/aurora/client/cli/util.py 4e9b6362728ecfd6e8a6efbc433f63f42aef60ad


Diff: https://reviews.apache.org/r/26428/diff/


Testing
-------

./build-support/hooks/pre-commit 
Performing Python import order check.
SUCCESS
Performing Python checkstyle.
SUCCESS

$ build-support/python/checkstyle-check src


Thanks,

Maxim Khutornenko


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message