aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Wickman" <wick...@apache.org>
Subject Re: Review Request 26428: Fixing python style violations.
Date Wed, 08 Oct 2014 19:02:18 GMT


> On Oct. 7, 2014, 11:31 p.m., Brian Wickman wrote:
> > build-support/hooks/pre-commit, line 41
> > <https://reviews.apache.org/r/26428/diff/1/?file=714987#file714987line41>
> >
> >     the reason i didn't add this to the pre-commit is beause the default behavior
for the pre-commit hook is to only check the diff against master.  
> >     it's possible that it needs more context e.g. +-2 lines in the file beyond the
diff, so it might miss stuff.
> >     
> >     doing against source for every commit might be too time consuming.  out of curiosity,
how long does it take to run this check on your laptop?
> 
> Maxim Khutornenko wrote:
>     It's between 15-20 seconds now, which is much slower than usual but I'd rather make
it slower and useful or drop completely and rely on jenkins script. Your call.

We should either fix --diff or change its behavior to be more conservative by performing checkstyle
on the entire file if it is involved in the diff.  In the meantime, I will give a ship, since
pre-commits are still opt-in.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26428/#review55729
-----------------------------------------------------------


On Oct. 8, 2014, 12:17 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26428/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 12:17 a.m.)
> 
> 
> Review request for Aurora and Brian Wickman.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Pre-commit hook was no longer working properly. Added target to match jenkins definition.
> 
> 
> Diffs
> -----
> 
>   build-support/hooks/pre-commit 24646e7b1c43a0177beb0084dd2af4c4b3dc686c 
>   src/test/python/apache/aurora/client/api/test_updater.py fc6a057c6c650d9ac9800b009e544dfad0c809bf

>   src/test/python/apache/aurora/client/cli/test_status.py 38ffdb86c5f577ebf3a482128588331a63af15d1

>   src/test/python/apache/aurora/client/cli/util.py ff7eda20dbba073c8b24fbe3f4389292aab2d128

> 
> Diff: https://reviews.apache.org/r/26428/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/hooks/pre-commit 
> Performing Python import order check.
> SUCCESS
> Performing Python checkstyle.
> SUCCESS
> 
> $ build-support/python/checkstyle-check src
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message