aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 26300: Don't kill GC Executor after period of inactivity
Date Wed, 08 Oct 2014 17:08:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26300/#review55821
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On Oct. 3, 2014, 1:59 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26300/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 1:59 a.m.)
> 
> 
> Review request for Aurora, Ben Mahler, Vinod Kone, and Brian Wickman.
> 
> 
> Bugs: AURORA-788
>     https://issues.apache.org/jira/browse/AURORA-788
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The GC executor is configured to exit after 15 minutes of inactivity. This leads to a
race where the mesos slave gets a launchTask message for a GC executor just as the executor
has exited, causing TASK_LOST noise. This also increases the risk that a slave will lose its
GC executor due to the scheduler not being able to find a slot for it (since GC executors
will have a higher churn rate).
> 
> Cluster operators will still be able to deploy new versions of the GC executor as the
24-hour max lifetime limit is still in place. This patch only removes the inactivity limit.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47

>   src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943

> 
> Diff: https://reviews.apache.org/r/26300/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor:gc_executor
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message