aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26383: Health Check Disabler
Date Wed, 08 Oct 2014 16:49:38 GMT


> On Oct. 6, 2014, 10:55 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/config/schema/base.py, line 69
> > <https://reviews.apache.org/r/26383/diff/1/?file=714259#file714259line69>
> >
> >     Do we need to make this path configurable? I'm trying to think of a reason that
someone might want to change it, and I'm coming up blank, however I could envision a scenario
where someone does something malicious (intentionally or not) like sets this path to something
that shouldn't be removed (e.g. the artifact being run).

+1, knob uneeded


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26383/#review55590
-----------------------------------------------------------


On Oct. 6, 2014, 9:24 p.m., David Pan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26383/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 9:24 p.m.)
> 
> 
> Review request for Aurora, Joe Smith, Brian Wickman, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The health check disabler allows health checks for a job to be snoozed temporarily by
touching a snooze file in the job's sandbox.  The path of the snooze file and the snooze duration
can be set in the HealthCheckConfig.  The appropriate unit tests were modified/added.
> 
> The corresponding JIRA ticket is the following:
> https://issues.apache.org/jira/browse/AURORA-795
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 5166d45ddf95ae5d8afe39dd3b00654ac91857ec 
>   docs/configuration-tutorial.md 67998e9dab6ac429d96d7c0d2df959336b767f32 
>   src/main/python/apache/aurora/config/schema/base.py f12634f103c3eb20e43f37c25d9b0fc3e3d228ec

>   src/main/python/apache/aurora/executor/common/health_checker.py 4980411c847d12655cbb363404707ebd9f0bd163

>   src/test/python/apache/aurora/executor/common/BUILD c7f7a003c865d479ba6e3cd7b5349322f884f653

>   src/test/python/apache/aurora/executor/common/test_health_checker.py aa36415fa891fc523a3a376ffeca5d3cd5ceabec

> 
> Diff: https://reviews.apache.org/r/26383/diff/
> 
> 
> Testing
> -------
> 
> On vagrant in ~/aurora, I ran
> ./pants src/test/python/apache/aurora/executor::
> 
> 
> Thanks,
> 
> David Pan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message