aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26328: Improve handling of unknown errors in the aurora client.
Date Wed, 08 Oct 2014 01:05:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26328/#review55752
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96140>

    This will also catch KeyboardInterrupt, which is the main source of annoying stack noise.
Consider filtering it out to prevent false positives.



src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96142>

    s/returnen/returned/g



src/main/python/apache/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/26328/#comment96147>

    Is it writing into the current dir of the aurora.pex executable? Consider making root
path configurable instead with a more durable default value (e.g. somewhere under ~/). Otherwise,
the error reports are gone the very moment aurora version is upgraded by an automated process
(e.g. rsync).


- Maxim Khutornenko


On Oct. 6, 2014, 6:55 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26328/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2014, 6:55 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-779
>     https://issues.apache.org/jira/browse/aurora-779
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Improve handling of unknown errors in the aurora client.
> 
> Instead of dumping the stack on the user's terminal, or
> absorbing the error and generating a brief error
> message, the client now writes detailed information about
> the error is written into an error log file, and the
> user is given a clean error message referring them to that
> file for details.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/__init__.py e0c3050151bca1128ed7e476ec5133407a20f6c2

>   src/main/python/apache/aurora/client/cli/context.py 301531fcb443297facb78d87a18073c8b7fd4064

>   src/main/python/apache/aurora/client/cli/standalone_client.py 7c0975ce9d415b19b6704b9a772ee2619ac9a2af

>   src/test/python/apache/aurora/client/cli/test_api_from_cli.py 78f21d2f20cf71fa2dfe0614885d44d2948decd2

>   src/test/python/apache/aurora/client/cli/test_create.py 6e55188bdfc576506848605debb391288e696fe3

>   src/test/python/apache/aurora/client/cli/util.py e1ee884c06f3bc22bcd9e908ff61af9459a0b535

> 
> Diff: https://reviews.apache.org/r/26328/diff/
> 
> 
> Testing
> -------
> 
> New unit test.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message