aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 26288: Fixing log_response in context.py
Date Mon, 06 Oct 2014 17:43:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26288/#review55531
-----------------------------------------------------------



src/main/python/apache/aurora/client/cli/context.py
<https://reviews.apache.org/r/26288/#comment95906>

    If the client-side API is using a deprecated field of this structure, then that should
be fixed. We shouldn't be patching this to prevent the need to remove deprecations from the
client-side API.


- Mark Chu-Carroll


On Oct. 2, 2014, 6:28 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26288/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 6:28 p.m.)
> 
> 
> Review request for Aurora and Mark Chu-Carroll.
> 
> 
> Bugs: AURORA-786
>     https://issues.apache.org/jira/browse/AURORA-786
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fixing log_response in context.py
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c

>   src/test/python/apache/aurora/client/cli/BUILD 8ce6bd5b7faa1579372fb6935180ea982af64af8

>   src/test/python/apache/aurora/client/cli/test_context.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26288/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/tests/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message