aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Maxim Khutornenko" <ma...@apache.org>
Subject Re: Review Request 26298: Use a less broad retry loop for RPCs.
Date Fri, 03 Oct 2014 00:13:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26298/#review55292
-----------------------------------------------------------


| I also changed the test to avoid sleeping, which was eating a fixed 10 seconds of unit test
time.
Not really sure why it takes that long for you:

$ time ./pants src/test/python/apache/aurora/client/api:scheduler_client -k test_transient_error
...
real	0m3.602s
user	0m2.679s
sys	0m0.696s

- Maxim Khutornenko


On Oct. 3, 2014, 12:05 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26298/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 12:05 a.m.)
> 
> 
> Review request for Aurora, Mark Chu-Carroll and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A few times when making changes, i've found myself confused at a stalled test and spiked
CPU, only to find that my test should have failed, but an exception is trapped in this retry
loop.  The key change here is that unknown exceptions will break the loop.
> 
> Making this change pointed out what should have been a test failure in `test_transient_error`,
where an exception caused by an unexpected call to `getVersion` was swallowed.
> 
> I also changed the test to avoid sleeping, which was eating a fixed 10 seconds of unit
test time.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317

>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442

> 
> Diff: https://reviews.apache.org/r/26298/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python:all -vxs
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message