aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Chu-Carroll" <mchucarr...@twopensource.com>
Subject Re: Review Request 26137: Fix help for new update command.
Date Thu, 02 Oct 2014 20:19:02 GMT


> On Sept. 30, 2014, 2:32 a.m., Joe Smith wrote:
> > src/main/python/apache/aurora/client/cli/update.py, line 45
> > <https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45>
> >
> >     Could you update a test case to catch accessing these as properties to catch
accidental regressions?
> 
> David McLaughlin wrote:
>     Piggy backing this issue to add that my ship it is pending a test for this command
at least?

I don't know of any way to write a single test that would always catch this.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26137/#review54953
-----------------------------------------------------------


On Sept. 29, 2014, 11:05 a.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26137/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 11:05 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-748
>     https://issues.apache.org/jira/browse/aurora-748
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix help for new update command.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/update.py b4dd792dc12f19424c620f4d91748113e272f0c9

> 
> Diff: https://reviews.apache.org/r/26137/diff/
> 
> 
> Testing
> -------
> 
> manual testing.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message