aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David McLaughlin" <da...@dmclaughlin.com>
Subject Re: Review Request 26270: Fix multiple errors involving bindings, and fix result codes.
Date Thu, 02 Oct 2014 19:51:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26270/#review55239
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On Oct. 2, 2014, 6:24 p.m., Mark Chu-Carroll wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26270/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2014, 6:24 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Zameer Manji.
> 
> 
> Bugs: aurora-781
>     https://issues.apache.org/jira/browse/aurora-781
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix multiple errors involving bindings, and fix result codes.
> 
> - Cause an error to be raised by an unresolved binding in a configuration file.
> - Fix incorrect structuring of processed bindings.
> - Add a test to confirm that unbound parameters generate errors.
> 
> While I'm in the code, also fix a problem where result codes aren't returned correctly
> to the shell.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/client.py 0cb69448cd24372067ac845eca5862bc3d3a46a9

>   src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28

>   src/main/python/apache/aurora/client/cli/options.py c2d422ac2bc82fc387596e93040b49f722f8310f

>   src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f

>   src/test/python/apache/aurora/client/cli/test_create.py 31fa56f5edcfc97903725ab27ccc12c6a8f39ffc

>   src/test/python/apache/aurora/client/cli/util.py a50b83c571390374975accf75e31f392dbdaaa04

> 
> Diff: https://reviews.apache.org/r/26270/diff/
> 
> 
> Testing
> -------
> 
> Unit tests:
> - verified that tests fail if the binding code is disabled, but pass with in on.
> - added a new unit test to check that unresolved bindings generate an error.
> 
> 
> Thanks,
> 
> Mark Chu-Carroll
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message