aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26239: Add usernames to scheduler update operations.
Date Wed, 01 Oct 2014 18:49:26 GMT


> On Oct. 1, 2014, 6:49 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 288
> > <https://reviews.apache.org/r/26239/diff/1/?file=710192#file710192line288>
> >
> >     Since you allow an absent value, use Optional<String>
> >     
> >     Ditt down the call stack.

Ditto*


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26239/#review55110
-----------------------------------------------------------


On Oct. 1, 2014, 6:42 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26239/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2014, 6:42 p.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-772
>     https://issues.apache.org/jira/browse/AURORA-772
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add usernames to scheduler update operations.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 01fc345344e4ae807607f8f87e8a9974c3b69151

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java b8dafe077999c1f2d14bbc260c83386020460396

>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java faa21363b87505e4212574bb9872d1e03a0e8f24

>   src/main/resources/org/apache/aurora/scheduler/http/ui/update.html aaff5b21f3d20f00eaf98c29d0e5bf19b25f2f62

>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml
631ab2543dadb77b7fd1cae96adc9c0bd2f94b39 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.xml
9b7e8ba620b42cfb404c9c14eeee40f953918c73 
>   src/main/resources/org/apache/aurora/scheduler/storage/db/schema.sql 2894b617af082bfde1d44571868200271b38724d

>   src/main/thrift/org/apache/aurora/gen/api.thrift a1217edbcd36cbe02b09a549b71e87ee40ffc6c7

>   src/test/java/org/apache/aurora/scheduler/storage/db/DBJobUpdateStoreTest.java 1b1160f349d64bbcd4d20103a82f3b8eb1ca75d9

>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
60c1582d4211b79656797a84ca6a7a67c7fecdfe 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 8843990484756664a0c16c61303f1aa992e7686d

> 
> Diff: https://reviews.apache.org/r/26239/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message