Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============8967195388528387318=="
MIME-Version: 1.0
Subject: Re: Review Request 26123: Fail the build on lack of test coverage.
From: "Zameer Manji" <zmanji@twopensource.com>
To: "Kevin Sweeney" <kevints@apache.org>,
 "Maxim Khutornenko" <maxim@apache.org>,
 "Joshua Cohen" <jcohen@twopensource.com>
Cc: "Bill Farner" <wfarner@apache.org>,
 "Aurora" <reviews@aurora.incubator.apache.org>,
 "Zameer Manji" <zmanji@twopensource.com>
Date: Mon, 29 Sep 2014 20:53:01 -0000
Message-ID: <20140929205301.19041.96667@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Zameer Manji" <noreply@reviews.apache.org>
References: <20140927233812.14999.77451@reviews.apache.org>
In-Reply-To: <20140927233812.14999.77451@reviews.apache.org>
Reply-To: "Zameer Manji" <zmanji@twopensource.com>

--===============8967195388528387318==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Sept. 27, 2014, 4:38 p.m., Zameer Manji wrote:
> > Once this is commited, please make tickets for adding tests to these classes.
> 
> Bill Farner wrote:
>     I'm not sure how to best do this without either creating a ton of tickets that are bound to be forgotten, or a monster ticket that is difficult to track.  Any bright ideas?

I have no ideas. In that case feel free to ignore my request for tickets.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26123/#review54771
-----------------------------------------------------------


On Sept. 27, 2014, 4:25 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26123/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2014, 4:25 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This will fail the build if:
> - global line or branch coverage is below a threshold
> - a class has no test coverage
> - a class flagged as known to have no coverage gains coverage
> 
> Hopefully we can all contribute to whittle the legacy non-covered list down to zero.
> 
> 
> Diffs
> -----
> 
>   build.gradle eabf65c13749ca98929e6b845cbc5f0d248003d6 
> 
> Diff: https://reviews.apache.org/r/26123/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Bill Farner
> 
>


--===============8967195388528387318==--