Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C0F5C17812 for ; Mon, 29 Sep 2014 17:23:10 +0000 (UTC) Received: (qmail 23651 invoked by uid 500); 29 Sep 2014 17:23:10 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 23607 invoked by uid 500); 29 Sep 2014 17:23:10 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 23596 invoked by uid 99); 29 Sep 2014 17:23:10 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 17:23:10 +0000 X-ASF-Spam-Status: No, hits=-1998.4 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 29 Sep 2014 17:23:08 +0000 Received: (qmail 23485 invoked by uid 99); 29 Sep 2014 17:22:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Sep 2014 17:22:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id BC3F51DBB60; Mon, 29 Sep 2014 17:22:45 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5188574697566849478==" MIME-Version: 1.0 Subject: Re: Review Request 26095: Fix instance summary visualisation. From: "Maxim Khutornenko" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "David McLaughlin" Date: Mon, 29 Sep 2014 17:22:45 -0000 Message-ID: <20140929172245.19041.35312@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26095/ X-Sender: "Maxim Khutornenko" References: <20140929161106.18846.18951@reviews.apache.org> In-Reply-To: <20140929161106.18846.18951@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5188574697566849478== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26095/#review54829 ----------------------------------------------------------- Ship it! Ship It! - Maxim Khutornenko On Sept. 29, 2014, 4:11 p.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26095/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 4:11 p.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-755 > https://issues.apache.org/jira/browse/AURORA-755 > > > Repository: aurora > > > Description > ------- > > See JIRA ticket. > > > Diffs > ----- > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 92c78c28020d36b978f1a098202174015ace1316 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8ed95737ea69112d4ee04b687281d06a21d6abf6 > > Diff: https://reviews.apache.org/r/26095/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Growing a job shows correct instance ids > https://reviews.apache.org/media/uploaded/files/2014/09/26/246430ff-cf02-4701-9254-6f8e42f95b2a__Screen_Shot_2014-09-26_at_12.47.45_PM.png > Instances removed are identified when shrinking job from 5 instances to 1 > https://reviews.apache.org/media/uploaded/files/2014/09/26/b01c5d23-080e-4433-804b-c868215c0bcb__Screen_Shot_2014-09-26_at_12.47.56_PM.png > > > Thanks, > > David McLaughlin > > --===============5188574697566849478==--