Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32C7B1797B for ; Thu, 25 Sep 2014 21:24:41 +0000 (UTC) Received: (qmail 24027 invoked by uid 500); 25 Sep 2014 21:24:41 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 23983 invoked by uid 500); 25 Sep 2014 21:24:41 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 23972 invoked by uid 99); 25 Sep 2014 21:24:40 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 21:24:40 +0000 X-ASF-Spam-Status: No, hits=-1998.6 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 25 Sep 2014 21:24:39 +0000 Received: (qmail 23759 invoked by uid 99); 25 Sep 2014 21:24:19 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 21:24:19 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 74E9A1DDA67; Thu, 25 Sep 2014 21:24:16 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1636683072685074259==" MIME-Version: 1.0 Subject: Re: Review Request 26012: Use BufferedOutputStream for deflater From: "Kevin Sweeney" To: "Bill Farner" , "Joe Smith" , "David McLaughlin" Cc: "Aurora" , "Kevin Sweeney" , "Maxim Khutornenko" Date: Thu, 25 Sep 2014 21:24:16 -0000 Message-ID: <20140925212416.15000.33198@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26012/ X-Sender: "Kevin Sweeney" References: <20140925013605.15006.2597@reviews.apache.org> In-Reply-To: <20140925013605.15006.2597@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1636683072685074259== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26012/ ----------------------------------------------------------- (Updated Sept. 25, 2014, 2:24 p.m.) Review request for Aurora, David McLaughlin, Joe Smith, and Bill Farner. Changes ------- Add explanatory comment. Repository: aurora Description ------- Use BufferedOutputStream for deflater Diffs (updated) ----- src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java 45cf7ecf52582ba3fd7bbc8b4a981e396793da4b Diff: https://reviews.apache.org/r/26012/diff/ Testing ------- ./gradlew build Also put together a microbenchmark with a scheduler backup from my production environment - using a BufferedOutputStream gets a 4sec speedup with no reduction in compression ratio. ¯_(?)_/¯ # Deflater.BEST_SPEED, No buffer deflate: 11745ms total:12734ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, buf = 512KiB deflate: 11015ms total:12001ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream deflate: 6885ms total:7694ms compression ratio: 647270930/121616834 = 532.22% # Deflater.BEST_SPEED, BufferedOutputStream at 512KiB deflate: 6752ms total:7585ms compression ratio: 647270930/121616834 = 532.22% # Deflater.DEFAULT_COMPRESSION deflate: 16664ms total:17219ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, buf size = 512KiB deflate: 16516ms total:17103ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream deflate: 12241ms total:12788ms compression ratio: 647270930/92690409 = 698.31% # Deflater.DEFAULT_COMPRESSION, BufferedOutputStream at 512KiB deflate: 11548ms total:12108ms compression ratio: 647270930/92690409 = 698.31% Thanks, Kevin Sweeney --===============1636683072685074259==--