Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 536CE171D7 for ; Thu, 25 Sep 2014 18:26:31 +0000 (UTC) Received: (qmail 15195 invoked by uid 500); 25 Sep 2014 18:26:31 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 15150 invoked by uid 500); 25 Sep 2014 18:26:31 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 15139 invoked by uid 99); 25 Sep 2014 18:26:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 18:26:30 +0000 X-ASF-Spam-Status: No, hits=-1998.6 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 25 Sep 2014 18:26:29 +0000 Received: (qmail 14834 invoked by uid 99); 25 Sep 2014 18:26:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 18:26:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 506561DDA42; Thu, 25 Sep 2014 18:26:07 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0253731503692849301==" MIME-Version: 1.0 Subject: Re: Review Request 25970: Adding support for retryable storage errors. From: "Maxim Khutornenko" To: "Bill Farner" , "Brian Wickman" , "Mark Chu-Carroll" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 25 Sep 2014 18:26:07 -0000 Message-ID: <20140925182607.14999.18342@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25970/ X-Sender: "Maxim Khutornenko" References: <20140925181612.15000.80729@reviews.apache.org> In-Reply-To: <20140925181612.15000.80729@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0253731503692849301== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25970/ ----------------------------------------------------------- (Updated Sept. 25, 2014, 6:26 p.m.) Review request for Aurora, Mark Chu-Carroll, Bill Farner, and Brian Wickman. Changes ------- CR comments. Bugs: AURORA-187 https://issues.apache.org/jira/browse/AURORA-187 Repository: aurora Description ------- Adding a new ERROR_RETRYABLE thrift response type to enable response-aware retrying in scheduler_client. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java 671dbd1b14e759f02f655909857099368255f214 src/main/java/org/apache/aurora/scheduler/storage/Storage.java 775564e1de0bec7fcfd96ea5ee3ee4948567e58f src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java a21ab901d86f74d5bc22bfffc09029c99d3a398f src/main/python/apache/aurora/client/api/scheduler_client.py ec632516655bbca4782e01310518843ce8aca27e src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/python/apache/aurora/client/api/test_scheduler_client.py 527448f882c12fe9bb51ce2a0a4c330188838282 Diff: https://reviews.apache.org/r/25970/diff/ Testing ------- gradle -Pq build ./pants src/test/python:all Thanks, Maxim Khutornenko --===============0253731503692849301==--