Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16CEF114FB for ; Thu, 25 Sep 2014 02:11:58 +0000 (UTC) Received: (qmail 60618 invoked by uid 500); 25 Sep 2014 02:11:58 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 60578 invoked by uid 500); 25 Sep 2014 02:11:58 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 60567 invoked by uid 99); 25 Sep 2014 02:11:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 02:11:57 +0000 X-ASF-Spam-Status: No, hits=-1998.6 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 25 Sep 2014 02:11:35 +0000 Received: (qmail 59552 invoked by uid 99); 25 Sep 2014 02:11:32 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Sep 2014 02:11:32 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 847B81DDA2C; Thu, 25 Sep 2014 02:11:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6330314663784168432==" MIME-Version: 1.0 Subject: Re: Review Request 26014: Quick fix for cron error. From: "Bill Farner" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora" , "Mark Chu-Carroll" Date: Thu, 25 Sep 2014 02:11:30 -0000 Message-ID: <20140925021130.14999.36222@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/26014/ X-Sender: "Bill Farner" References: <20140925015706.15000.5121@reviews.apache.org> In-Reply-To: <20140925015706.15000.5121@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6330314663784168432== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26014/#review54498 ----------------------------------------------------------- Fix + test is up here: https://reviews.apache.org/r/26015/ - Bill Farner On Sept. 25, 2014, 1:57 a.m., Mark Chu-Carroll wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26014/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 1:57 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: aurora-753 > https://issues.apache.org/jira/browse/aurora-753 > > > Repository: aurora > > > Description > ------- > > Damned python indent-syntax - else clause attached to "if" rather than "for". > > > Diffs > ----- > > src/main/python/apache/aurora/client/cli/cron.py 3416c8e1932056725880f2007b60d77112759428 > > Diff: https://reviews.apache.org/r/26014/diff/ > > > Testing > ------- > > Quick fix: no additional test. I'll add a regression test when rosh hashanah is over. > > > Thanks, > > Mark Chu-Carroll > > --===============6330314663784168432==--