Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 40AE5117CE for ; Tue, 23 Sep 2014 16:48:55 +0000 (UTC) Received: (qmail 90789 invoked by uid 500); 23 Sep 2014 16:48:54 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 90753 invoked by uid 500); 23 Sep 2014 16:48:54 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 90735 invoked by uid 99); 23 Sep 2014 16:48:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Sep 2014 16:48:54 +0000 X-ASF-Spam-Status: No, hits=-1998.6 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 23 Sep 2014 16:48:53 +0000 Received: (qmail 84822 invoked by uid 99); 23 Sep 2014 16:48:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Sep 2014 16:48:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B49FE1DD8F1; Tue, 23 Sep 2014 16:48:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0333660668320018494==" MIME-Version: 1.0 Subject: Re: Review Request 25812: Implementing quota checking for async job updates. From: "Maxim Khutornenko" To: "Bill Farner" , "Kevin Sweeney" , "David McLaughlin" Cc: "Aurora" , "Maxim Khutornenko" Date: Tue, 23 Sep 2014 16:48:30 -0000 Message-ID: <20140923164830.15006.4628@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Maxim Khutornenko" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25812/ X-Sender: "Maxim Khutornenko" References: <20140923161244.15006.85878@reviews.apache.org> In-Reply-To: <20140923161244.15006.85878@reviews.apache.org> Reply-To: "Maxim Khutornenko" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============0333660668320018494== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25812/ ----------------------------------------------------------- (Updated Sept. 23, 2014, 4:48 p.m.) Review request for Aurora, David McLaughlin, Kevin Sweeney, and Bill Farner. Changes ------- CR comments. Bugs: AURORA-686 https://issues.apache.org/jira/browse/AURORA-686 Repository: aurora Description ------- Getting it right required a deep refactoring of the QuotaManager. The prod consumption is now calculated from: - production tasks not participating in job updates; - unaffected production tasks from a job being updated (i.e. those that are not covered by the update working set); - production tasks directly affected by the job update (max of old and new resources used). Also, moved all logic back to SchedulerThriftInterface as quota checks are done only there now. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 14b0dd8f86026840d0444c128f656a144eab017d src/main/java/org/apache/aurora/scheduler/state/StateModule.java 54b90127551c69509dbd41ee95c384dbbf1a7ee4 src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 70333737ee119ea083f0ac17a4205e7af9f4c753 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java ae0320b44b55a3630e255484ea7a881daab6a7bc src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 8f9e6d6fa00840d8ff94eb7cf1c4415eb5cc1269 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 348bdbfbb51800d31b67ea1b3f2632975e598306 src/main/thrift/org/apache/aurora/gen/api.thrift 2376a5e530b12fbbebb4cfc7555656ae07795518 src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 8381e2126c62c40d28a325c72686d01e82bb84cf src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java 5aebbfbc691dfac4a066cb1425d18d3fccc77090 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 21e8a8ba5c47f549133ea339899bf0e5097ccbb9 src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java 40156c211a346664c0d2f174235efb2049cf3bb9 Diff: https://reviews.apache.org/r/25812/diff/ Testing ------- gradle -Pq build Thanks, Maxim Khutornenko --===============0333660668320018494==--