Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C6C311AE6 for ; Mon, 22 Sep 2014 18:53:04 +0000 (UTC) Received: (qmail 58057 invoked by uid 500); 22 Sep 2014 18:53:04 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 58015 invoked by uid 500); 22 Sep 2014 18:53:04 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 58003 invoked by uid 99); 22 Sep 2014 18:53:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 18:53:04 +0000 X-ASF-Spam-Status: No, hits=-1998.6 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 22 Sep 2014 18:52:41 +0000 Received: (qmail 57808 invoked by uid 99); 22 Sep 2014 18:52:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Sep 2014 18:52:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B71A31DD885; Mon, 22 Sep 2014 18:52:36 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2396829971032032498==" MIME-Version: 1.0 Subject: Re: Review Request 25870: Use AssistedInject to allow guice to construct StreamManager From: "Kevin Sweeney" To: "Bill Farner" , "Maxim Khutornenko" Cc: "Aurora" , "Kevin Sweeney" Date: Mon, 22 Sep 2014 18:52:36 -0000 Message-ID: <20140922185236.15006.63612@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25870/ X-Sender: "Kevin Sweeney" References: <20140920011934.16263.39422@reviews.apache.org> In-Reply-To: <20140920011934.16263.39422@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============2396829971032032498== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25870/ ----------------------------------------------------------- (Updated Sept. 22, 2014, 11:52 a.m.) Review request for Aurora, Maxim Khutornenko and Bill Farner. Changes ------- Maxim's feedback Repository: aurora Description ------- Use Guice AssistedInject to construct StreamManager Refactor other component in log to be Guice-constructed. More info: https://github.com/google/guice/wiki/AssistedInject Diffs (updated) ----- build.gradle e51912116c2a205bb85f229b167ddb3e1b3b7883 src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/LogManager.java 87bd6579409e4f397f1efaa10192e271e022cade src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 816f4504f067daab3b86e1885390957ace9d4f7b src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 23ee32bcde0129716a4e652995640351b13d4b4f src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 899416fceae498353880012b8a93491cff461064 src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 0cfa73f7d802b50e92e802956e0c67291fb26eb7 src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 8fbade1dc14ca6e061ae59f1ab688c8f1563d4aa Diff: https://reviews.apache.org/r/25870/diff/ Testing ------- ./gradlew -Pq build Also manually verified that the annotated methods are exported in vagrant (by using aurora_admin scheduler_snapshot devcluster and looking at /vars) Thanks, Kevin Sweeney --===============2396829971032032498==--