Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A3C0B11A5E for ; Thu, 18 Sep 2014 20:49:05 +0000 (UTC) Received: (qmail 88514 invoked by uid 500); 18 Sep 2014 20:49:05 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 88470 invoked by uid 500); 18 Sep 2014 20:49:05 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 88458 invoked by uid 99); 18 Sep 2014 20:49:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Sep 2014 20:49:05 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 18 Sep 2014 20:49:03 +0000 Received: (qmail 88333 invoked by uid 99); 18 Sep 2014 20:48:43 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Sep 2014 20:48:43 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 860771DD84D; Thu, 18 Sep 2014 20:48:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8791170488620201505==" MIME-Version: 1.0 Subject: Re: Review Request 25791: Save instance update events when updating a job. From: "Bill Farner" To: "Maxim Khutornenko" , "David McLaughlin" Cc: "Bill Farner" , "Aurora" , "Joshua Cohen" Date: Thu, 18 Sep 2014 20:48:41 -0000 Message-ID: <20140918204841.7800.31484@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25791/ X-Sender: "Bill Farner" References: <20140918204600.7800.25942@reviews.apache.org> In-Reply-To: <20140918204600.7800.25942@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8791170488620201505== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25791/ ----------------------------------------------------------- (Updated Sept. 18, 2014, 8:48 p.m.) Review request for Aurora, David McLaughlin and Maxim Khutornenko. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description ------- A follow-up change will scope the updaters to actionable instance changes, which will remove the redundant actions being saved (see TODOs). Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java 0442191d3a84e1a6bbeb2a79fda78ef077ee0d04 src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java 34f12a9ff0f265561e349800f972a10db41a9fec src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 33bf7c7e6eeb538cf14fb3b9e58ae058390f7e05 src/main/java/org/apache/aurora/scheduler/updater/SideEffect.java d9e59b6c1270f70235c4d0c38a8df7ce70499768 src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 0e15a79ae6dc877dfa6ba492efafdf1f89f7d40f Diff: https://reviews.apache.org/r/25791/diff/ Testing ------- ./gradlew build -Pq Thanks, Bill Farner --===============8791170488620201505==--