Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C98811C23 for ; Tue, 16 Sep 2014 19:25:23 +0000 (UTC) Received: (qmail 20050 invoked by uid 500); 16 Sep 2014 19:25:23 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 20004 invoked by uid 500); 16 Sep 2014 19:25:22 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 19992 invoked by uid 99); 16 Sep 2014 19:25:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 19:25:22 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 16 Sep 2014 19:25:21 +0000 Received: (qmail 19856 invoked by uid 99); 16 Sep 2014 19:25:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 16 Sep 2014 19:25:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 1BA921DD78D; Tue, 16 Sep 2014 19:24:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1654131477440221064==" MIME-Version: 1.0 Subject: Re: Review Request 25259: Add update information to the scheduler UI From: "Kevin Sweeney" To: "Bill Farner" , "Kevin Sweeney" , "Joshua Cohen" Cc: "David McLaughlin" , "Aurora" Date: Tue, 16 Sep 2014 19:24:59 -0000 Message-ID: <20140916192459.7801.58728@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25259/ X-Sender: "Kevin Sweeney" References: <20140916182940.7800.90994@reviews.apache.org> In-Reply-To: <20140916182940.7800.90994@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1654131477440221064== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25259/#review53570 ----------------------------------------------------------- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js I think you can use .constant here and drop the top-level function () - Kevin Sweeney On Sept. 16, 2014, 11:29 a.m., David McLaughlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25259/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2014, 11:29 a.m.) > > > Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner. > > > Bugs: AURORA-614 > https://issues.apache.org/jira/browse/AURORA-614 > > > Repository: aurora > > > Description > ------- > > Adds update history to the job page. Adds an update details page. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 0336a6e00a9a7e14125eaae271788faaae0bd371 > src/main/resources/org/apache/aurora/scheduler/http/ui/breadcrumb.html c780b0fe98863b5421824a9652a7202da9f4302a > src/main/resources/org/apache/aurora/scheduler/http/ui/css/app.css 2a752313cb8ae404605a9458b33237a911eec061 > src/main/resources/org/apache/aurora/scheduler/http/ui/job.html e21dee015897eee62ade8f74e26f042b8e2be734 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/app.js fb3b5b12121a6e8a30dbf6fe069557f69a563408 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js 3477b7e667459665af9d9dc9d2456793822bc7f7 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/directives.js 7f05a552f3786adb115ff9648f4fadce968230e9 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js 76f48f8aa2399c83fbafe8efcf6f4f3e47ab05a0 > src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js e898f12a7b6c6c35b4bce5a8aa78f3fcaa83a6df > src/main/resources/org/apache/aurora/scheduler/http/ui/timeDisplay.html PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/update.html PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/http/ui/updateSettings.html PRE-CREATION > src/main/thrift/org/apache/aurora/gen/api.thrift a6dc548c804bfcb9166573496023bad80b2a2c91 > > Diff: https://reviews.apache.org/r/25259/diff/ > > > Testing > ------- > > ./gradlew jsHint > > > File Attachments > ---------------- > > job page > https://reviews.apache.org/media/uploaded/files/2014/09/09/531eca81-a0ba-4438-8bd6-4b50d97b0270__job-progress-small-preview.png > update page > https://reviews.apache.org/media/uploaded/files/2014/09/09/8e3f2950-7d7e-404e-bca9-6c472b5218f7__update-page-finished.png > > > Thanks, > > David McLaughlin > > --===============1654131477440221064==--