Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 295FB11A43 for ; Mon, 15 Sep 2014 19:13:24 +0000 (UTC) Received: (qmail 39274 invoked by uid 500); 15 Sep 2014 19:13:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 39230 invoked by uid 500); 15 Sep 2014 19:13:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 39219 invoked by uid 99); 15 Sep 2014 19:13:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Sep 2014 19:13:23 +0000 X-ASF-Spam-Status: No, hits=-1998.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 15 Sep 2014 19:13:01 +0000 Received: (qmail 38887 invoked by uid 99); 15 Sep 2014 19:12:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Sep 2014 19:12:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 4EF9C1DB842; Mon, 15 Sep 2014 19:12:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7924858611779786610==" MIME-Version: 1.0 Subject: Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates. From: "Kevin Sweeney" To: "Kevin Sweeney" Cc: "Aurora" , "Brian Wickman" Date: Mon, 15 Sep 2014 19:12:57 -0000 Message-ID: <20140915191257.7800.4722@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25175/ X-Sender: "Kevin Sweeney" References: <20140915180817.7800.20322@reviews.apache.org> In-Reply-To: <20140915180817.7800.20322@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7924858611779786610== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review53385 ----------------------------------------------------------- Ship it! Please circle back and add test coverage - Kevin Sweeney On Sept. 15, 2014, 11:08 a.m., Brian Wickman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25175/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2014, 11:08 a.m.) > > > Review request for Aurora and Kevin Sweeney. > > > Bugs: AURORA-669 > https://issues.apache.org/jira/browse/AURORA-669 > > > Repository: aurora > > > Description > ------- > > Fix possible deadlock in TaskRunner.collect_updates. > > > Diffs > ----- > > src/main/python/apache/thermos/core/runner.py ec4cdb788a1e24a590b262ba8dbd044cf31fc198 > > Diff: https://reviews.apache.org/r/25175/diff/ > > > Testing > ------- > > Filed https://issues.apache.org/jira/browse/AURORA-709 to track adding test coverage for this. > > > Thanks, > > Brian Wickman > > --===============7924858611779786610==--