Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11C1111D8D for ; Fri, 12 Sep 2014 23:05:25 +0000 (UTC) Received: (qmail 28807 invoked by uid 500); 12 Sep 2014 23:05:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 28762 invoked by uid 500); 12 Sep 2014 23:05:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 28750 invoked by uid 99); 12 Sep 2014 23:05:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 23:05:24 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 12 Sep 2014 23:05:01 +0000 Received: (qmail 28307 invoked by uid 99); 12 Sep 2014 23:04:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 23:04:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A4CA91DD751; Fri, 12 Sep 2014 23:04:57 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============8915795686735935535==" MIME-Version: 1.0 Subject: Re: Review Request 25459: Adding quota check into startJobUpdate. From: "Bill Farner" To: "Bill Farner" , "David McLaughlin" Cc: "Aurora" , "Maxim Khutornenko" Date: Fri, 12 Sep 2014 23:04:57 -0000 Message-ID: <20140912230457.23924.5912@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25459/ X-Sender: "Bill Farner" References: <20140909003051.23924.87178@reviews.apache.org> In-Reply-To: <20140909003051.23924.87178@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============8915795686735935535== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25459/#review53238 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java You mean inclusive? src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java This treats the update as though it is purely additive. e.g. if i'm updating my job, i'm charged for 2x that job's resources. I believe the algorithm we'll need to use is max(before_update, after_update) when determining the impact of an update. The trouble here becomes visibility, we need to do some follow-up UI work so users aren't baffled when they're being charged for a paused update. - Bill Farner On Sept. 9, 2014, 12:30 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25459/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:30 a.m.) > > > Review request for Aurora, David McLaughlin and Bill Farner. > > > Bugs: AURORA-649 > https://issues.apache.org/jira/browse/AURORA-649 > > > Repository: aurora > > > Description > ------- > > Wiring TaskLimitValidator into the startJobUpdate API. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java 3661f8487985f631e3ea437fe6430e0296376a9e > src/main/java/org/apache/aurora/scheduler/state/TaskLimitValidator.java 779e925e4d9e7889e8cfd369cea9a8e5da3554d2 > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 > src/test/java/org/apache/aurora/scheduler/state/TaskLimitValidatorTest.java 8f18617b2052201f87bb1464314c2ee45b279276 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e > > Diff: https://reviews.apache.org/r/25459/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============8915795686735935535==--