Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5B4511B10 for ; Fri, 12 Sep 2014 21:44:24 +0000 (UTC) Received: (qmail 36618 invoked by uid 500); 12 Sep 2014 21:44:24 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 36573 invoked by uid 500); 12 Sep 2014 21:44:24 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 36562 invoked by uid 99); 12 Sep 2014 21:44:24 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 21:44:24 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 12 Sep 2014 21:44:01 +0000 Received: (qmail 35305 invoked by uid 99); 12 Sep 2014 21:43:59 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Sep 2014 21:43:59 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 15A521DD749; Fri, 12 Sep 2014 21:43:58 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6850994896811237027==" MIME-Version: 1.0 Subject: Re: Review Request 25593: Use a ServletContextListener to configure servlets From: "Kevin Sweeney" To: "Bill Farner" , "Joshua Cohen" , "David McLaughlin" Cc: "Aurora" , "Kevin Sweeney" Date: Fri, 12 Sep 2014 21:43:58 -0000 Message-ID: <20140912214358.23924.53504@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Kevin Sweeney" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25593/ X-Sender: "Kevin Sweeney" References: <20140912213944.23923.92577@reviews.apache.org> In-Reply-To: <20140912213944.23923.92577@reviews.apache.org> Reply-To: "Kevin Sweeney" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============6850994896811237027== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25593/ ----------------------------------------------------------- (Updated Sept. 12, 2014, 2:43 p.m.) Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner. Changes ------- jcohen's feedback Repository: aurora Description ------- This paves the way for ShiroWebModule integration. As an added benefit Guice is now instantiating our servlets for us (no injector.getInstance calls in our code). Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 9d8654b4268a13fc9d29d12f8da2c1aa8fda4b2b Diff: https://reviews.apache.org/r/25593/diff/ Testing ------- ./gradlew -Pq build No new tests added - the existing JerseyServletModuleTests already cover correctness of wiring. Thanks, Kevin Sweeney --===============6850994896811237027==--