Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: reviews@aurora.incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============6484350192605939940=="
MIME-Version: 1.0
Subject: Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs
From: "Bill Farner" <wfarner@apache.org>
To: "Bill Farner" <wfarner@apache.org>,
 "David McLaughlin" <david@dmclaughlin.com>
Cc: "Aurora" <reviews@aurora.incubator.apache.org>,
 "Joshua Cohen" <jcohen@twopensource.com>
Date: Thu, 11 Sep 2014 18:48:07 -0000
Message-ID: <20140911184807.23923.37394@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Bill Farner" <noreply@reviews.apache.org>
References: <20140911182016.23924.32699@reviews.apache.org>
In-Reply-To: <20140911182016.23924.32699@reviews.apache.org>
Reply-To: "Bill Farner" <wfarner@apache.org>

--===============6484350192605939940==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25548/#review53084
-----------------------------------------------------------

Ship it!


Ship It!

- Bill Farner


On Sept. 11, 2014, 6:20 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25548/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2014, 6:20 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Bill Farner.
> 
> 
> Bugs: AURORA-697
>     https://issues.apache.org/jira/browse/AURORA-697
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Apply GzipFilter to POSTs as well as GETs
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 83ba0e49436034c8b6f9f736c60a726686096362 
>   src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 2c31df6d0ac1c58e02b13d61ba9f511b781a20a7 
> 
> Diff: https://reviews.apache.org/r/25548/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> Also verified content-encoding against response from scheduler in vagrant image:
> 
> $ curl -s -D - -o /dev/null -H "Accept-Encoding: gzip" -X POST -d @- \
> >         http://192.168.33.7:8081/api <<EOF |tr '\r' '\n' |grep "Content-Encoding" |awk '{print $2}' \
> >         |tr '[:upper:]' '[:lower]'
> > [1,"getJobSummary",1,0,{"1":{"str":"vagrant"}}]
> > EOF
> gzip
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>


--===============6484350192605939940==--