Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3CC7D113AE for ; Thu, 11 Sep 2014 18:14:13 +0000 (UTC) Received: (qmail 10846 invoked by uid 500); 11 Sep 2014 18:14:13 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 10800 invoked by uid 500); 11 Sep 2014 18:14:13 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 10789 invoked by uid 99); 11 Sep 2014 18:14:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2014 18:14:12 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 11 Sep 2014 18:14:11 +0000 Received: (qmail 10488 invoked by uid 99); 11 Sep 2014 18:13:51 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Sep 2014 18:13:51 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0FDB21DD665; Thu, 11 Sep 2014 18:13:50 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4149116502323565189==" MIME-Version: 1.0 Subject: Re: Review Request 25481: Adding JobUpdateRequest validation. From: "Zameer Manji" To: "Bill Farner" , "Zameer Manji" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 11 Sep 2014 18:13:50 -0000 Message-ID: <20140911181350.23929.91468@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Zameer Manji" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25481/ X-Sender: "Zameer Manji" References: <20140909194630.23923.37941@reviews.apache.org> In-Reply-To: <20140909194630.23923.37941@reviews.apache.org> Reply-To: "Zameer Manji" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============4149116502323565189== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53073 ----------------------------------------------------------- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java I'm a little unfamilar with JobUpdateRequest and this RPC but it seems we should update "StartJobUpdateResult" to have a message field that we can surface to the user? - Zameer Manji On Sept. 9, 2014, 12:46 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25481/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 12:46 p.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Bugs: AURORA-649 > https://issues.apache.org/jira/browse/AURORA-649 > > > Repository: aurora > > > Description > ------- > > Adding JobUpdateRequest validation. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e > > Diff: https://reviews.apache.org/r/25481/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============4149116502323565189==--