Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C962B11F20 for ; Fri, 5 Sep 2014 20:19:47 +0000 (UTC) Received: (qmail 59663 invoked by uid 500); 5 Sep 2014 20:19:47 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 59620 invoked by uid 500); 5 Sep 2014 20:19:47 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 59609 invoked by uid 99); 5 Sep 2014 20:19:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2014 20:19:47 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 05 Sep 2014 20:19:25 +0000 Received: (qmail 54965 invoked by uid 99); 5 Sep 2014 20:19:22 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2014 20:19:22 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id ABE8C1DD4B3; Fri, 5 Sep 2014 20:19:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1278970590666663976==" MIME-Version: 1.0 Subject: Re: Review Request 25356: Add a factory to produce OneWayUpdate instances based on job state and update settings. From: "Bill Farner" To: "Maxim Khutornenko" , "Zameer Manji" Cc: "Bill Farner" , "Aurora" Date: Fri, 05 Sep 2014 20:19:21 -0000 Message-ID: <20140905201921.13389.79977@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25356/ X-Sender: "Bill Farner" References: <20140905175207.13389.20578@reviews.apache.org> In-Reply-To: <20140905175207.13389.20578@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1278970590666663976== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25356/ ----------------------------------------------------------- (Updated Sept. 5, 2014, 8:19 p.m.) Review request for Aurora, Maxim Khutornenko and Zameer Manji. Bugs: AURORA-613 https://issues.apache.org/jira/browse/AURORA-613 Repository: aurora Description ------- This is the bridge between the top-level updater logic and the OneWayJobUpdater - taking a user request and the direction we've decided to move the job (forward or back), produce the appropriate OneWayJobUpdater. Diffs (updated) ----- src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java 85196af38b6615e5aac7de30a4a601350e935c72 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java aa8b5f2ee81d42db003f27e682f79e94b6625d87 src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactory.java PRE-CREATION src/main/java/org/apache/aurora/scheduler/updater/StateEvaluator.java dca55ef5612105c9dc8fd57e789fdf1df28ba447 src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java d7baaa679289998a9ea80c0934990a49e5c173d7 src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterFactoryImplTest.java PRE-CREATION src/test/java/org/apache/aurora/scheduler/updater/OneWayJobUpdaterTest.java e3e50d7d6526e8796dc5cd82b459190b09ceb72f Diff: https://reviews.apache.org/r/25356/diff/ Testing ------- ./gradlew build -Pq Thanks, Bill Farner --===============1278970590666663976==--