Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C7A711C50 for ; Fri, 5 Sep 2014 00:50:43 +0000 (UTC) Received: (qmail 38687 invoked by uid 500); 5 Sep 2014 00:50:42 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 38644 invoked by uid 500); 5 Sep 2014 00:50:42 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 38633 invoked by uid 99); 5 Sep 2014 00:50:42 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2014 00:50:42 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 05 Sep 2014 00:50:40 +0000 Received: (qmail 38152 invoked by uid 99); 5 Sep 2014 00:50:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Sep 2014 00:50:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7FC7F1DD464; Fri, 5 Sep 2014 00:50:19 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7497571709590335313==" MIME-Version: 1.0 Subject: Re: Review Request 25337: Preserve executor HealthCheckerThread name From: "Brian Wickman" To: "Brian Wickman" , "Maxim Khutornenko" , "David McLaughlin" Cc: "Aurora" , "Joe Smith" Date: Fri, 05 Sep 2014 00:50:19 -0000 Message-ID: <20140905005019.16960.47264@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brian Wickman" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25337/ X-Sender: "Brian Wickman" References: <20140905004356.16961.46637@reviews.apache.org> In-Reply-To: <20140905004356.16961.46637@reviews.apache.org> Reply-To: "Brian Wickman" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============7497571709590335313== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52389 ----------------------------------------------------------- \m/ src/main/python/apache/aurora/executor/common/health_checker.py make _healthy and _reason non-private src/main/python/apache/aurora/executor/common/health_checker.py super(HealthChecker, self).start() src/main/python/apache/aurora/executor/common/health_checker.py think you'll need an extra newline here for checkstyle to not complain src/test/python/apache/aurora/executor/common/test_health_checker.py please obtain an ephemeral port here instead. who is to say that port 9001 is not running a service that accepts the health check protocol? or at the very least, create a mock HttpSignaler src/test/python/apache/aurora/executor/common/test_health_checker.py all of these attributes should likely be public or read-only properties of private attributes src/test/python/apache/aurora/executor/common/test_health_checker.py the + is superfluous src/test/python/apache/aurora/executor/test_thermos_executor.py derp? - Brian Wickman On Sept. 5, 2014, 12:43 a.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25337/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 12:43 a.m.) > > > Review request for Aurora, David McLaughlin, Maxim Khutornenko, and Brian Wickman. > > > Bugs: AURORA-682 > https://issues.apache.org/jira/browse/AURORA-682 > > > Repository: aurora > > > Description > ------- > > Preserve executor HealthCheckerThread name > > > Diffs > ----- > > src/main/python/apache/aurora/executor/common/health_checker.py 603fff35b839c6f53d9379ec047d7d8135a1c65b > src/test/python/apache/aurora/executor/common/BUILD 3229facf40070929adabb57fef667ab11bf3d1ec > src/test/python/apache/aurora/executor/common/fixtures.py PRE-CREATION > src/test/python/apache/aurora/executor/common/test_health_checker.py 490d4c8b5c434f9d6f032d931e35c483b3a5b676 > src/test/python/apache/aurora/executor/common/test_task_info.py 344fd675c9a1ef9c88e39c16ac0f1dd50a9c1632 > > Diff: https://reviews.apache.org/r/25337/diff/ > > > Testing > ------- > > ###STILL RUNNING E2E TESTS > > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/isort-run > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./build-support/python/checkstyle-check > [tw-mbp13-jsmith aurora (yasumoto/fix_health_checker_name)]$ ./pants ./src/test/python/apache/aurora/executor:all > src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS > src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS > src.test.python.apache.aurora.executor.common.executor_timeout ..... SUCCESS > src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS > src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS > src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS > src.test.python.apache.aurora.executor.executor_base ..... SUCCESS > src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS > src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS > src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS > src.test.python.apache.aurora.executor.status_manager ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS > > > Thanks, > > Joe Smith > > --===============7497571709590335313==--