Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B015B11D5B for ; Thu, 4 Sep 2014 17:44:52 +0000 (UTC) Received: (qmail 74403 invoked by uid 500); 4 Sep 2014 17:44:52 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 74311 invoked by uid 500); 4 Sep 2014 17:44:52 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 74274 invoked by uid 99); 4 Sep 2014 17:44:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Sep 2014 17:44:51 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 04 Sep 2014 17:44:50 +0000 Received: (qmail 72290 invoked by uid 99); 4 Sep 2014 17:44:30 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Sep 2014 17:44:30 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C50111DD425; Thu, 4 Sep 2014 17:44:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5152821647034023283==" MIME-Version: 1.0 Subject: Re: Review Request 24915: Adding initial GC task delay on scheduler restart. From: "Bill Farner" To: "Bill Farner" Cc: "Aurora" , "Maxim Khutornenko" Date: Thu, 04 Sep 2014 17:44:29 -0000 Message-ID: <20140904174429.16961.9862@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Bill Farner" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/24915/ X-Sender: "Bill Farner" References: <20140820233519.15059.54620@reviews.apache.org> In-Reply-To: <20140820233519.15059.54620@reviews.apache.org> Reply-To: "Bill Farner" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============5152821647034023283== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24915/#review52328 ----------------------------------------------------------- Per offline discussion, i've realized my memory leak concern is ~moot since we already have the unbounded HostAttributes store. I liked your suggestion of augmenting the way this soft state is used: - use a Map, no expiry - when receiving an offer, don't kick off a GC task if a map entry is not present, store a future timestamp after which we should launch a GC task - Bill Farner On Aug. 20, 2014, 11:35 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24915/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 11:35 p.m.) > > > Review request for Aurora and Bill Farner. > > > Bugs: AURORA-608 > https://issues.apache.org/jira/browse/AURORA-608 > > > Repository: aurora > > > Description > ------- > > Adding initial GC task delay on scheduler restart. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 5a38a1f69ac5dbe68af3bfe175899ddee392880b > src/main/java/org/apache/aurora/scheduler/async/GcExecutorLauncher.java 65f404915bc60ffe11a7a57d9861ac5b37fa646a > src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java 04137072891b2a1f0ad663182629dd469b09324f > > Diff: https://reviews.apache.org/r/24915/diff/ > > > Testing > ------- > > gradle -Pq build > > > Thanks, > > Maxim Khutornenko > > --===============5152821647034023283==--