Return-Path: X-Original-To: apmail-aurora-reviews-archive@minotaur.apache.org Delivered-To: apmail-aurora-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 23EC011D05 for ; Wed, 3 Sep 2014 01:42:58 +0000 (UTC) Received: (qmail 9975 invoked by uid 500); 3 Sep 2014 01:42:58 -0000 Delivered-To: apmail-aurora-reviews-archive@aurora.apache.org Received: (qmail 9931 invoked by uid 500); 3 Sep 2014 01:42:57 -0000 Mailing-List: contact reviews-help@aurora.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@aurora.incubator.apache.org Delivered-To: mailing list reviews@aurora.incubator.apache.org Received: (qmail 9918 invoked by uid 99); 3 Sep 2014 01:42:57 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 01:42:57 +0000 X-ASF-Spam-Status: No, hits=-1999.5 required=5.0 tests=ALL_TRUSTED,HTML_MESSAGE,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Sep 2014 01:42:33 +0000 Received: (qmail 7794 invoked by uid 99); 3 Sep 2014 01:42:31 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2014 01:42:31 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 41E261DD3C8; Wed, 3 Sep 2014 01:42:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1872602607756396948==" MIME-Version: 1.0 Subject: Re: Review Request 25208: Increment Mesos version to 0.20.0 From: "Joe Smith" To: "Brian Wickman" , "Maxim Khutornenko" , "Kevin Sweeney" Cc: "Aurora" , "Joe Smith" Date: Wed, 03 Sep 2014 01:42:30 -0000 Message-ID: <20140903014230.16968.27151@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Joe Smith" X-ReviewGroup: Aurora X-ReviewRequest-URL: https://reviews.apache.org/r/25208/ X-Sender: "Joe Smith" References: <20140902180821.16960.94848@reviews.apache.org> In-Reply-To: <20140902180821.16960.94848@reviews.apache.org> Reply-To: "Joe Smith" X-ReviewRequest-Repository: aurora X-Virus-Checked: Checked by ClamAV on apache.org --===============1872602607756396948== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Sept. 2, 2014, 11:08 a.m., Brian Wickman wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py, lines 45-50 > > > > > > should these be > > > > mesos_pb2.TASK_LOST > > mesos_pb2.TASK_KILLED > > > > ...etc? Absolutely- great catch! - Joe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52049 ----------------------------------------------------------- On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25208/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 5:45 p.m.) > > > Review request for Aurora, Kevin Sweeney, Maxim Khutornenko, and Brian Wickman. > > > Bugs: AURORA-674 > https://issues.apache.org/jira/browse/AURORA-674 > > > Repository: aurora > > > Description > ------- > > There's an API change when moving the python executor to 0.20.0, which should deserve extra scrutiny. > > > Diffs > ----- > > 3rdparty/python/BUILD edc446e6d76d53a4c10a703cf6e84e29b8d42366 > Vagrantfile c8cb2d440330780c10eeff47d46cc1a3f1aa4910 > build.gradle 66c8205c8354048c398623edf7ba75e721376b01 > examples/vagrant/provision-dev-cluster.sh 2ce74f8a6dc663b62d254bc9d3a5c06cb412107f > src/main/python/apache/aurora/executor/BUILD c1c50dbcdcaa56f8ff970ceac59d5db537e1d048 > src/main/python/apache/aurora/executor/aurora_executor.py 8985aeb60e2c890113ea7d25039cdab5b7c9a19e > src/main/python/apache/aurora/executor/bin/BUILD 93517150db96600c92ea25c0de29ec20736d72f7 > src/main/python/apache/aurora/executor/bin/gc_executor_main.py bc20dad1e5434a98fb51ab052efa8ced760e74e0 > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py aacc19a3bd272b08dee8a77d7a64490d0fcad3fa > src/main/python/apache/aurora/executor/common/BUILD 0a4d35afcbfca8730d8bb7373795f9b3b6a74fd7 > src/main/python/apache/aurora/executor/common/health_checker.py 671f4970d4637b8cb68ec89e5dfe96a2f4cd077b > src/main/python/apache/aurora/executor/common/kill_manager.py 6e482cfa7d2e081804fe6992527bae0ac5b65080 > src/main/python/apache/aurora/executor/common/status_checker.py eda30e38d34adc5c78b828d0aea31f0721bf9b20 > src/main/python/apache/aurora/executor/executor_base.py c632b77d972f76f3e260bb7413aa6100cda46607 > src/main/python/apache/aurora/executor/gc_executor.py c45d5eb9a99e310e0716abd626ca34615f63b0ae > src/main/python/apache/aurora/executor/thermos_task_runner.py 03a40e63573322f2d40e59a8ce84e9b9a1b90aa6 > src/test/python/apache/aurora/executor/BUILD 3152ec0c0e7dfaec5d756542a89243756b27725d > src/test/python/apache/aurora/executor/common/BUILD 6316c7fc724c8e2245f5ce1a93c4a2daecd9f26b > src/test/python/apache/aurora/executor/common/test_executor_timeout.py PRE-CREATION > src/test/python/apache/aurora/executor/common/test_health_checker.py baeaba29e7679203d83f6ea81455973baf07f324 > src/test/python/apache/aurora/executor/common/test_kill_manager.py PRE-CREATION > src/test/python/apache/aurora/executor/common/test_status_checker.py 6ca4fd469bdc7cd21033ccdea460292463bc1cf8 > src/test/python/apache/aurora/executor/test_executor_base.py PRE-CREATION > src/test/python/apache/aurora/executor/test_gc_executor.py 0b2278a94667ca4d43e8a84649ed5312acacf7bb > src/test/python/apache/aurora/executor/test_status_manager.py PRE-CREATION > src/test/python/apache/aurora/executor/test_thermos_executor.py 55747a19478572e39d1f00f799727d3c3db174c9 > src/test/python/apache/aurora/executor/test_thermos_task_runner.py f7af70fda8fef91018ff9d10dc1db6d43fd16ac7 > > Diff: https://reviews.apache.org/r/25208/diff/ > > > Testing > ------- > > $ ./gradlew test > > [tw-mbp13-jsmith aurora (yasumoto/mesos_0.20.0)]$ ./build-support/python/checkstyle-check && ./pants ./src/test/python/apache/aurora/executor:all > src.test.python.apache.aurora.executor.common.announcer ..... SUCCESS > src.test.python.apache.aurora.executor.common.directory_sandbox ..... SUCCESS > src.test.python.apache.aurora.executor.common.health_checker ..... SUCCESS > src.test.python.apache.aurora.executor.common.status_checker ..... SUCCESS > src.test.python.apache.aurora.executor.common.task_info ..... SUCCESS > src.test.python.apache.aurora.executor.executor_base ..... SUCCESS > src.test.python.apache.aurora.executor.executor_detector ..... SUCCESS > src.test.python.apache.aurora.executor.executor_vars ..... SUCCESS > src.test.python.apache.aurora.executor.gc_executor ..... SUCCESS > src.test.python.apache.aurora.executor.status_manager ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_executor ..... SUCCESS > src.test.python.apache.aurora.executor.thermos_task_runner ..... SUCCESS > > > Thanks, > > Joe Smith > > --===============1872602607756396948==--