aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Farner" <wfar...@apache.org>
Subject Re: Review Request 26160: Fixing consumption double counting in quota checks.
Date Tue, 30 Sep 2014 03:07:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26160/#review54945
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java
<https://reviews.apache.org/r/26160/#comment95268>

    method name is no longer correct



src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java
<https://reviews.apache.org/r/26160/#comment95267>

    can you rephrease this in terms of what it _does_ rather than does _not_ do?
    
    ditto for the test case below


- Bill Farner


On Sept. 30, 2014, 1:32 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26160/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 1:32 a.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Bugs: AURORA-768
>     https://issues.apache.org/jira/browse/AURORA-768
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Accounting for both initial and desired states when filtering out non updating tasks.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java a0da417623ac6c3c592fe22cc7c897d74151bfe1

>   src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java 9d02474751ed22cb2dfd7903aa715d53b5ac805e

>   src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java f961494adafce0e815175f59a7dd4037bec52559

> 
> Diff: https://reviews.apache.org/r/26160/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message