aurora-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zameer Manji" <zma...@twopensource.com>
Subject Re: Review Request 25974: Prevent initial ZK timeouts from killing the executor.
Date Tue, 30 Sep 2014 00:55:06 GMT


> On Sept. 29, 2014, 4:43 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/executor/common/announcer.py, lines 112-116
> > <https://reviews.apache.org/r/25974/diff/4/?file=708538#file708538line112>
> >
> >     this data is available within the mesos_task struct created in from_assigned_task.
 you should be getting the information from there as it may contain default values not required
to be populated in the executorConfig json (in which case you'd be getting KeyErrors from
make_serverset.)

done.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25974/#review54916
-----------------------------------------------------------


On Sept. 29, 2014, 5:54 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25974/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 5:54 p.m.)
> 
> 
> Review request for Aurora, Kevin Sweeney, Bill Farner, and Brian Wickman.
> 
> 
> Bugs: AURORA-728
>     https://issues.apache.org/jira/browse/AURORA-728
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Prevent initial ZK timeouts from killing the executor. In addition, prevent uncaught
exceptions from killing the executor.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 79a24855b2a68271b7478395dfdadab8755c3af2

>   src/main/python/apache/aurora/executor/common/announcer.py c466da8d48bbc2aa227c2db157cab84665ad6602

>   src/test/python/apache/aurora/executor/common/test_announcer.py 4f6e200ecb1a4ea7cb45acd466a57f19d5815326

> 
> Diff: https://reviews.apache.org/r/25974/diff/
> 
> 
> Testing
> -------
> 
> ./pants src/test/python/apache/aurora/executor:executor-small
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message